Fix a few mesh template UV bugs - #3732
Open
ewanhowell5195 wants to merge 7 commits into
Open
ewanhowell5195 wants to merge 7 commits into
ewanhowell5195 wants to merge 7 commits into
Conversation
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
|
Snapping to pixel intentionally doesn't happen on complex UV islands. For example, try to create a "Tube" shape mesh with default settings and generate a template. You'll see that at the ends of the tube the UV on some faces are wonky and pixels are no longer square. I like the alignment change on symmetrical faces, and the fix of the extra pixel row. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1052.
Rounding only ran on islands made of a single quad, so anything
combine_polysmerged from two or more faces never got snapped to the pixel grid. It now runs for every quad in an island. Seams between two faces are left alone, snapping those just stretches one face and squashes the other.Before:
After:
I also fixed two other things I ran into while testing this.
Islands were aligned flush to one side, so a symmetric face came out with a lopsided staircase. They are now centred on any axis they are symmetrical about.
Before:
After:
The rect used to work out which pixels a face covers was inclusive at its low corner but exclusive at its high one, so an edge sitting exactly on a pixel boundary painted the pixel past it.
Before:
After: