PR for #149: Address stata builder bugs#165
Open
liaochris wants to merge 17 commits into
Open
Conversation
Closed
Collaborator
Author
|
/run-actions-all --post |
|
Triggered by @liaochris on this comment Check Results (run details)
|
Closed
jmshapir
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this issue I addressed two things.
.dofiles can't contain periods because stata batch mode creates logs that are named based on everything up to the first period. Sofile.doandfile.v2.doshare the logfile.log, which creates collision errors. I fixed this by having the stata builder prohibit periods in file stems.sconsfails to raise errors when.dofiles fail since stata doesn't return a non-zero exit code when it fails. I fixed this by updating the scons builder to detect whenstatabuilds fail.