Repository navigation
in-363-ppl-영상-검색이-안나옴-문제-해결 -> develop - #215
Merged
Hidden character warning
The head ref may contain hidden characters: "in-363-ppl-\uc601\uc0c1-\uac80\uc0c9\uc774-\uc548\ub098\uc634-\ubb38\uc81c-\ud574\uacb0"
Merged
Conversation
Walkthrough
ChangeschannelId 타입 String → Long 전환
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryApi.java`:
- Around line 33-34: The API documentation is inconsistent because the
`@Operation` description on `ChannelBrandHistoryApi` still refers to the old
`(YouTube 채널 ID)` wording while the `channelId` parameter is now documented as a
numeric channel ID. Update the `@Operation` text in the same controller so it
matches the `@Parameter` for `channelId`, and keep the terminology consistent
with the new identifier across the method documentation.
In
`@src/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryController.java`:
- Line 26: The `ChannelBrandHistoryController` path variable semantics are
changing from YouTube channel ID to internal DB ID under the same `v1` URI,
which breaks existing clients that still send `UC...` values. Update the
controller contract so `channelId` remains backward compatible, or split the new
internal-ID behavior into a separate `/v2` endpoint; if both must coexist,
adjust the controller methods to accept both identifiers during a migration
period.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1612b686-ec77-46a7-816d-ee51c09b9705
📒 Files selected for processing (3)
src/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryApi.javasrc/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryController.javasrc/main/java/com/example/inflace/domain/brandcollaboration/service/ChannelBrandHistoryService.java
Comment on lines
+33
to
+34
| @Parameter(description = "채널 ID", example = "1701") | ||
| @PathVariable Long channelId, |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
검색 API 설명이 아직 이전 식별자를 가리킵니다.
@Parameter는 숫자형 채널 ID로 바뀌었는데, @Operation 설명의 Line 24는 아직 (YouTube 채널 ID)라고 적혀 있습니다. 이 상태로는 생성된 OpenAPI에서 같은 파라미터를 서로 다르게 설명하게 됩니다.
문서 문구 정리 예시
- - `channelId`는 Path Variable로 전달합니다. (YouTube 채널 ID)
+ - `channelId`는 Path Variable로 전달합니다. (로그인 응답의 channelId)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@src/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryApi.java`
around lines 33 - 34, The API documentation is inconsistent because the
`@Operation` description on `ChannelBrandHistoryApi` still refers to the old
`(YouTube 채널 ID)` wording while the `channelId` parameter is now documented as a
numeric channel ID. Update the `@Operation` text in the same controller so it
matches the `@Parameter` for `channelId`, and keep the terminology consistent
with the new identifier across the method documentation.
| @GetMapping("/{channelId}") | ||
| public BaseResponse<CursorSliceResponse<ChannelBrandHistoryVideoResponse>> search( | ||
| @PathVariable String channelId, | ||
| @PathVariable Long channelId, |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
같은 v1 경로에서 식별자 의미를 바꾸면 기존 클라이언트가 바로 깨집니다.
이 변경은 URI는 그대로 두고 channelId를 YouTube 채널 ID에서 내부 DB ID로 바꾸기 때문에, 기존 호출자가 보내던 "UC..." 값은 이제 컨트롤러 바인딩 단계에서 400으로 떨어집니다. 호환성 계획이 없다면 /v2로 분리하거나, 일정 기간 두 식별자를 함께 받아서 마이그레이션할 수 있게 해야 합니다.
Also applies to: 35-35
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@src/main/java/com/example/inflace/domain/brandcollaboration/controller/ChannelBrandHistoryController.java`
at line 26, The `ChannelBrandHistoryController` path variable semantics are
changing from YouTube channel ID to internal DB ID under the same `v1` URI,
which breaks existing clients that still send `UC...` values. Update the
controller contract so `channelId` remains backward compatible, or split the new
internal-ID behavior into a separate `/v2` endpoint; if both must coexist,
adjust the controller methods to accept both identifiers during a migration
period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
comment
Summary by CodeRabbit