Repository navigation
feat: AI 인사이트 및 S3 이미지 업로드 인프라 설정 개선 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
82a2b50
feat: Gemini AI 조건부 빈 설정 개선
Junhyukkkk 0f27b26
feat: S3 조건부 빈 설정 개선
Junhyukkkk e20e4f9
fix: 투표 결과 인사이트 locked 상태 처리 수정
Junhyukkkk 682d6eb
chore: 배포 스크립트에 S3, Gemini, Firebase 설정 추가
Junhyukkkk ddfa5d0
chore: 로컬/테스트 환경 설정 파일 업데이트
Junhyukkkk 463a953
refactor: VoteResultResponse 필드명 isMyGroup으로 통일 및 테스트 수정
Junhyukkkk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/java/com/ject/vs/vote/adapter/web/dto/FreeVotesResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package com.ject.vs.vote.adapter.web.dto; | ||
|
|
||
| public record FreeVotesResponse(int remainingFreeVotes, int totalFreeVotes) { | ||
| public record FreeVotesResponse(Integer remainingFreeVotes, Integer totalFreeVotes) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,3 +53,20 @@ management: | |
| endpoint: | ||
| health: | ||
| show-details: never | ||
|
|
||
| # Firebase 푸시 알림 (선택적 - 파일이 없으면 자동 비활성화) | ||
| firebase: | ||
| service-account-path: secret/firebase-service-account.json | ||
|
|
||
| # Gemini AI 인사이트 | ||
| gemini: | ||
| project-id: jectvsserver | ||
| enabled: true | ||
|
|
||
| # AWS S3 이미지 업로드 | ||
| aws: | ||
| s3: | ||
| bucket: ject-vs-images | ||
| region: ap-southeast-2 | ||
| access-key: ${AWS_S3_ACCESS_KEY} | ||
| secret-key: ${AWS_S3_SECRET_KEY} | ||
|
Comment on lines
+61
to
+72
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. local 프로필에서 외부 연동을 기본 활성화하면 “의존성 없이 실행” 목표와 충돌합니다. Line 61-64( 🔧 제안 수정안 gemini:
- project-id: jectvsserver
- enabled: true
+ enabled: ${GEMINI_ENABLED:false}
+ project-id: ${GEMINI_PROJECT_ID:}
aws:
s3:
- bucket: ject-vs-images
- region: ap-southeast-2
- access-key: ${AWS_S3_ACCESS_KEY}
- secret-key: ${AWS_S3_SECRET_KEY}
+ bucket: ${AWS_S3_BUCKET:}
+ region: ${AWS_S3_REGION:ap-southeast-2}
+ access-key: ${AWS_S3_ACCESS_KEY:}
+ secret-key: ${AWS_S3_SECRET_KEY:}🤖 Prompt for AI Agents |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firebase 시크릿 파일은 비어있는 값일 때 생성하지 말고 권한을 제한해주세요.
Line 133-135은
FIREBASE_SERVICE_ACCOUNT_JSON이 비어도 파일을 생성해 optional 동작을 깨뜨립니다(빈 JSON 파일 마운트). 또한 서비스 계정 파일 권한 제한이 없어 민감정보 노출 위험이 있습니다.🔧 제안 수정안
📝 Committable suggestion
🤖 Prompt for AI Agents