fix: parse #[Depends] attributes when building retry filters#17
Merged
ItzNotABug merged 2 commits intoJul 16, 2026
Merged
Conversation
PHPUnit 10+ suites use #[Depends] instead of @Depends docblocks. Without attribute support, retries omit prerequisites, PHPUnit skips the failed test, and exit 0 falsely marks the suite as passed. Co-authored-by: Cursor <cursoragent@cursor.com>
ChiragAgg5k
force-pushed
the
fix/phpunit-depends-attributes
branch
from
July 16, 2026 08:33
f5478cd to
ab2624a
Compare
ChiragAgg5k
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
ItzNotABug
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[Depends('…')](and the FQCN attribute form) in addition to@dependsdocblocks.Why
Retries filter failed tests via the dependency graph. Suites that only use PHPUnit 10 attributes (e.g. Appwrite Cloud e2e) had an empty graph, so retries ran the failed method alone → PHPUnit skipped it → exit 0 → false green.
Test plan
bun test tests/unit/