chore: migrate action runtime from node20 to node24#15
Merged
Conversation
Node 20 is deprecated on GitHub Actions runners (default is now Node 24), so every workflow using this action prints a deprecation warning. The bundle is built with `bun build --target node` (no version pin) and uses only @actions/* libraries, so it runs unchanged on Node 24.
ChiragAgg5k
added a commit
to appwrite/appwrite
that referenced
this pull request
Jun 21, 2026
ItzNotABug/php-retry#15 migrated the action runtime from the deprecated node20 to node24. The v3 tag has not been re-pointed yet, so pin the merged commit (d4500b9) directly to clear the "Node 20 is being deprecated" warning on the unit-test retry step. Updates all 5 pins.
ChiragAgg5k
added a commit
to appwrite/appwrite
that referenced
this pull request
Jun 22, 2026
… tests (#12637) * (test): report true per-test duration and de-duplicate variable build tests The PHPUnit test reporter printed `durationSinceStart()` — wall-clock elapsed since the run began — and labeled it as per-test duration. That made the numbers climb monotonically across the run and flagged nearly every test past the 15s mark as "slow", even pure CRUD tests that finish in well under a second. Capture an elapsed-since-start stamp when each test is prepared and subtract it at finish, so the reported time and the "slow" warning are the test's own duration. Separately, the variable-in-build integration tests (testProjectVariableInFunction, testProjectVariableInSite) lived in the shared VariablesBase trait and therefore ran in both the console-client and custom-server suites — 4 real Docker/npm builds where 2 suffice. The contract is auth-side independent, so move them into VariablesCustomServerTest only and keep the cheap CRUD coverage shared. * (test): satisfy rector string-cast rule and document refactor pre-check Rector's StringCastAssertStringContainsStringRector requires (string) casts on the assertStringContains(Not) arguments in the moved build tests. Apply them, and add composer refactor / refactor:check to the AGENTS.md command table so the CI "Refactor" check is run before pushing. * fix: purge project cache after config updates * (test): stamp test start at PreparationStarted, not Prepared Prepared fires after setUp/fixtures run, so expensive e2e setup was excluded from the reported per-test duration and the slow-test warning. Listen on PreparationStarted (before preparation begins) instead, and rename the subscriber to match. * (ci): bump php-retry to node24 runtime commit ItzNotABug/php-retry#15 migrated the action runtime from the deprecated node20 to node24. The v3 tag has not been re-pointed yet, so pin the merged commit (d4500b9) directly to clear the "Node 20 is being deprecated" warning on the unit-test retry step. Updates all 5 pins. * (ci): combine PHP check jobs into a single Checks job * (test): use full-precision duration in per-test reporter durationSinceStart()->seconds() returns only the whole-second part, so the finish-minus-start delta dropped all sub-second time: a 10.9s→11.1s test reported 1000ms instead of ~200ms, and most sub-second tests reported 0ms. Use Duration::asFloat() (seconds + nanoseconds) for both the start stamp and the finish elapsed, and format output as rounded integer ms / 2-decimal seconds. * fix: remove project cache purge calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the action runtime in
action.ymlfromnode20tonode24.Why
GitHub has deprecated Node 20 on Actions runners — the default is now Node 24. Every workflow that uses
itznotabug/php-retrycurrently prints:(see the GitHub changelog).
Declaring
node24removes the warning and runs on the runner's default runtime.Compatibility
dist/index.jsis produced bybun build ./src/index.ts --target nodewith no Node-version pin, so the emitted CJS bundle is forward-compatible.@actions/core,@actions/exec,@actions/github,fast-xml-parser,tree-kill— none require Node 20-specific behavior; all are supported on Node 24.distrebuild needed; only the runtime declaration changes.