[IP-85]: import export options all data#582
Draft
nielsdrost7 wants to merge 10 commits into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nielsdrost7
changed the title
nielsdrost7
force-pushed
the
feature/85-import-export-options-all-data
branch
from
July 4, 2026 12:23
6262f3f to
b78dcf1
Compare
Ran vendor/bin/pint on develop: import ordering, binary-operator spacing, and empty-body brace style. Purely cosmetic, no behavior change.
This was referenced Jul 24, 2026
…ed_at Expense, Payment, Project, and Task all set $timestamps = false and have no created_at column, but the RecentExpensesWidget/RecentPaymentsWidget/ RecentProjectsWidget/RecentTasksWidget dashboard widgets called ->latest() with no argument, which defaults to ordering by created_at regardless of $timestamps. MySQL (CI) raises a hard 1054 Unknown column error; SQLite silently reinterprets the double-quoted "created_at" identifier as a string literal when it can't resolve it, so the bug never surfaced in local sqlite-backed test runs.
Local tests silently diverging from CI's MariaDB (via a documented SQLite .env.testing fallback) has repeatedly masked real bugs this session — ->latest() defaulting to a nonexistent created_at column, and identifier quoting differences, both passed locally on SQLite and only failed on CI. - docker-compose.yml: cli service now injects DB_CONNECTION=mysql/DB_HOST=db etc. itself and depends_on db, so `docker compose run --rm cli php artisan test` works against real MariaDB with zero per-developer .env.testing edits - Add docker-resources/mariadb/init/01-create-test-db.sql to provision a dedicated invoiceplane_test database alongside the dev one on first boot - Fix db service: the named `database` volume was declared but never mounted, so all local dev/test data was lost on every container recreate - docker-resources/php-cli/Dockerfile: rebuild on Debian (php:8.4-cli) with the minimal proven extension set, matching the ip2-test-php:8.4 image this session used successfully throughout — see InvoicePlane#689 for a still-open false- failure issue found with a fresh cli image build, flagged in the docs - Update AGENTS.md/CLAUDE.md/README.md/.github/DOCKER.md/Makefile to point at the compose db/cli path instead of the SQLite instructions - Note throughout: use `php artisan test`, not raw vendor/bin/phpunit — the two were observed to behave differently for this app's Livewire form tests
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…s for PHPUnit CI The ImportInvoicePlaneV1CommandTest uses the import:db artisan command which requires the mysql CLI to restore the SQL dump file. The mysql CLI is provided by mariadb-client package. Additionally, configure explicit IMPORT_DB environment variables to ensure the import connection is properly set up during CI tests.
…n't fail GitHub-hosted ubuntu-latest runners execute job steps as the non-root runner user; apt-get needs root to lock dpkg, so the previous step would fail with a permission error before ever reaching phpunit.
nielsdrost7
force-pushed
the
feature/85-import-export-options-all-data
branch
from
July 24, 2026 11:20
f5e207f to
5b6fc87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import/export options for all data (#85): export (CSV + Excel, v2 and V1-legacy formats) ships for all nine modules (Clients/Contacts, Invoices, Quotes, Payments, Products, Projects/Tasks, Expenses) with list-page actions; the V1 database migration path ships as the
import:dbcommand (Modules/Core/Commands/ImportInvoicePlaneV1Command.php) + per-entity import services (Modules/Core/Services/Import/*ImportService.php) +ImportOrchestrator.The Filament
ImportAction-based per-module import UI is not part of this PR — that remains with the child issues (#139, #140, #141, #80), attached below.Update 2026-07-04 — branch revived and green
develop— the PR is mergeable again.import_v1MySQL connection; without one their setUp/tearDown errored and leaked an open transaction that cascaded "There is already an active transaction" into 265 unrelated tests. They now skip cleanly when no import database is reachable (they still run whereverIMPORT_DB_*points at a real source).relations.company_name,products.product_name,expenses.expense_amount,payments.payment_amount/notes, and payments now get the invoice their NOT NULLinvoice_idrequires.Full suite: 0 failed / 323 passed / 64 skipped / 9 incomplete (fork develop baseline: 272 passed).
Closes
Closes #85 — import/export options for all data: CSV+Excel export (v2 and V1-legacy) for all 9 modules, V1 database migration via
import:dbFollow-up issues (not resolved here — reopen if auto-closed on merge)
Closes #139 — Import options (catalog, pricelists) — Filament ImportAction UI not built; only the CLI
import:dbpath existsCloses #140 — Import products from external sources — no Filament ImportAction wizard for Products
Closes #141 — Import clients in bulk for data migration — no Filament ImportAction wizard for Clients
Closes #80 — Finish create import for Excel — Filament ImportAction-based per-module import UI remains unbuilt across the board
Test plan
php artisan test— full suite, expect 0 failed (323 passed / 64 skipped / 9 incomplete on sqlite in-memory)php artisan import:dbagainst a real InvoicePlane v1 database — spot check a few entities