Skip to content

Skip tensor tests by default in conda recipe to avoid OOM#2860

Open
vlad-perevezentsev wants to merge 2 commits intoinclude-dpctl-tensorfrom
skip_tensor_tests
Open

Skip tensor tests by default in conda recipe to avoid OOM#2860
vlad-perevezentsev wants to merge 2 commits intoinclude-dpctl-tensorfrom
skip_tensor_tests

Conversation

@vlad-perevezentsev
Copy link
Copy Markdown
Contributor

Tensor tests require significant device memory and frequently cause OOM crashes on internal CI machines during conda package testing (mostly on Linux) often manifesting as Python abort signals instead of regular failures.

This PR sets SKIP_TENSOR_TESTS=1 by default in conda recipe test scripts to avoid such crashes.

Users or CI environments can opt in by setting SKIP_TENSOR_TESTS=0 on systems with sufficient memory.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@github-actions
Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2860/index.html

Comment thread CHANGELOG.md
* Updated QR tests to avoid element-wise comparisons for `raw` and `r` modes [#2785](https://github.com/IntelPython/dpnp/pull/2785)
* Moved all SYCL kernel functors from `backend/extensions/` to a unified `backend/kernels/` directory hierarchy [#2816](https://github.com/IntelPython/dpnp/pull/2816)
* `dpnp` uses pybind11 3.0.3 [#2834](https://github.com/IntelPython/dpnp/pull/2834)
* Disabled `dpnp.tensor` tests by default in conda recipe to prevent OOM failures during package testing [#2859](https://github.com/IntelPython/dpnp/pull/2859)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd clear to mention explicit conda build --test ... command which is only affected. And also we need to state how it's possible to disable default behavior with setting env variable SKIP_TENSOR_TESTS=0 while running conda build --test ....

Comment thread CHANGELOG.md
* Updated QR tests to avoid element-wise comparisons for `raw` and `r` modes [#2785](https://github.com/IntelPython/dpnp/pull/2785)
* Moved all SYCL kernel functors from `backend/extensions/` to a unified `backend/kernels/` directory hierarchy [#2816](https://github.com/IntelPython/dpnp/pull/2816)
* `dpnp` uses pybind11 3.0.3 [#2834](https://github.com/IntelPython/dpnp/pull/2834)
* Disabled `dpnp.tensor` tests by default in conda recipe to prevent OOM failures during package testing [#2859](https://github.com/IntelPython/dpnp/pull/2859)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Disabled `dpnp.tensor` tests by default in conda recipe to prevent OOM failures during package testing [#2859](https://github.com/IntelPython/dpnp/pull/2859)
* Disabled `dpnp.tensor` tests by default in conda recipe to prevent OOM failures during package testing [#2860](https://github.com/IntelPython/dpnp/pull/2860)

@github-actions
Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.20.0dev6=py313h509198e_60 ran successfully.
Passed: 1357
Failed: 3
Skipped: 16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants