feat(deploy): carry app_url/app_name/env on deploy.healthy audit row#216
Merged
Conversation
The deploy.healthy audit metadata only had time_to_healthy_seconds, so the worker's new "your app is live at <url>" email had no URL to render. Add app_url/app_name/env to both deploy.healthy emit sites (fresh deploy + in-place redeploy). Fresh path reads result.AppURL (the in-memory struct isn't stamped yet); redeploy reuses the loaded d.AppURL. Pairs with the worker PR wiring deploy.created/healthy into the email forwarder. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deploy.healthyaudit metadata only carriedtime_to_healthy_seconds, so the worker's new "your app is live at " email had no URL to render.Adds
app_url/app_name/envto bothdeploy.healthyemit sites:runDeploy) — readsresult.AppURL(the in-memoryd.AppURLisn't stamped at that point, only the row was updated);runRedeployAsync) — reuses the loadedd.AppURL(URL is unchanged on in-place redeploy).deploy.createdalready carriedapp_name/env/ttl_policy, so no change needed there.Pairs with worker PR #75, which wires
deploy.created/deploy.healthyinto the email forwarder. Order-independent: if worker ships first, the live email simply falls back to the dashboard CTA until this lands.Verification
Local build + vet clean. The
deploy_audit_emittest asserts row counts by kind (unaffected by added metadata keys). Not yet verified live.🤖 Generated with Claude Code