Updated pnpm lock and fix use npx to call tailwindcss in shiro-types build script - #651
Open
lldxlzy wants to merge 18 commits into
Open
Updated pnpm lock and fix use npx to call tailwindcss in shiro-types build script#651lldxlzy wants to merge 18 commits into
lldxlzy wants to merge 18 commits into
Conversation
|
This pull request exceeds GitHub's diff limits and cannot be scanned. GitHub Limits:
Recommendations:
|
|
Someone is attempting to deploy a commit to the Innei's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
This is not a correct solution. You can add tailwindcss as a devDependency to its dependencies, and do not use webpack for building. |
Author
|
I don't think not to use webpack is a good thing... |
Author
|
I fixed it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xin the brackets)Description
This PR fixes a series of deployment disasters that made me question my life choices over the past few hours. Specifically:
"node": ">=20"from devDependencies: Yes, someone (me) actually put Node.js itself as an npm package dependency. pnpm happily installednode@26.7.0like it was a normal library, and Vercel cried. Moved toengineswhere it belongs.::highlight()is not valid CSS. It's a standard API, but apparently Turbopack in Next.js 16.1.6 disagrees. Added--webpackflag because I don't have time to wait for Turbopack to catch up with 2024.tailwindcss: command not foundin shiro-types: Works on my machine™, fails in Vercel CI. Classic. Changed tonpx tailwindcssbecause CI environments don't care about your local PATH.Linked Issues
fixes #649 (and several unreported screams into the void)
AI collaboration
I used Qwen as my debugging partner / emotional support / log analyzer throughout this ordeal. Without it, I would still be staring at
ERR_PNPM_OUTDATED_LOCKFILEwondering why Node.js is a devDependency.1. Workflow
nodeas a package was the root cause of EVERYTHING)2. Prompt (or equivalent task description)
Highlights include:
3. Reasoning and trade-offs
@haklex/rich-editoror wait for Turbopack to support::highlight, but both options require time I no longer have. Webpack is boring but reliable. Trade-off: builds are ~20% slower, but at least they finish.pnpm execwould work too, butnpxis more universal. If someone ever switches to yarn or bun (please don't), this won't break.nodepackage and workspace resolution failing. I was looking at lockfile errors; Qwen looked at the dependency tree and said "why is Node.js here?" That single insight saved hours.package.jsonchange, ranpnpm installlocally 4 times to confirm 1160 packages, tested build commands before pushing. AI suggested, I executed and validated.Additional context
pnpm-lock.yamlwas nuked and rebuilt. If you have uncommitted dependency changes, do not merge this yet. Rebase first or you'll lose work.--webpackis temporary. Once Turbopack supports::highlightor we update the rich editor, we can remove it. Feel free to open an issue to remind Future Us.--webpacktemporarily. Turbopack works fine in dev mode; only production build chokes on the CSS.🙏 Thanks to whoever reviews this.
QwQ