Skip to content

Improve packaging #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viceroypenguin merged 2 commits into from
Jun 3, 2026
Merged

Improve packaging #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
638ab6a
Improve packaging
viceroypenguin Jun 3, 2026
9fd75ba
Address build issue and CR
viceroypenguin Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:
push:
branches:
- 'master'
- 'main'
paths-ignore:
- '**/readme.md'
pull_request:
Expand Down Expand Up @@ -33,13 +33,21 @@ jobs:
dotnet-version: |
11.0.x

- name: Restore tools
run: dotnet tool restore
Comment thread
viceroypenguin marked this conversation as resolved.

- name: Restore dependencies
run: dotnet restore
- name: Build
run: dotnet build -c Release --no-restore
- name: Test
run: dotnet test -c Release --no-build -- --coverage --coverage-output-format cobertura --coverage-output coverage.cobertura.xml --coverage-settings ./coverage-settings.xml

- name: Package
run: dotnet pack -c Release --no-build --property:PackageOutputPath=../../nupkgs
Comment thread
viceroypenguin marked this conversation as resolved.
- name: Validate Package
run: dotnet tool run dotnet-validate -- package local ./nupkgs/*.nupkg

- name: Coveralls
uses: coverallsapp/github-action@v2
with:
Expand Down
7 changes: 4 additions & 3 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,15 @@
</PropertyGroup>

<ItemGroup>
<PackageVersion Include="DotNet.ReproducibleBuilds" Version="2.0.2" />
<PackageVersion Include="Immediate.Handlers" Version="3.8.0" />
<PackageVersion Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="4.14.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.Common" Version="4.8.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.4" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.8.0" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.7.0" />
<PackageVersion Include="MinVer" Version="7.0.0" />
<!-- Locked until https://github.com/microsoft/codecoverage/issues/221 resolved -->
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="[18.4.1]" />
<PackageVersion Include="xunit.v3.mtp-v2" Version="3.2.2" />
</ItemGroup>

Expand Down Expand Up @@ -54,7 +53,9 @@
</ItemGroup>

<ItemGroup>
<GlobalPackageReference Include="DotNet.ReproducibleBuilds" Version="2.0.2" PrivateAssets="All" />
<GlobalPackageReference Include="Meziantou.Analyzer" Version="3.0.98" PrivateAssets="All" />
<GlobalPackageReference Include="Meziantou.Polyfill" Version="1.0.140" PrivateAssets="All" />
<GlobalPackageReference Include="MinVer" Version="7.0.0" PrivateAssets="All" />
</ItemGroup>
</Project>
1 change: 1 addition & 0 deletions Immediate.Cache.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<File Path="coverage-settings.xml" />
<File Path="Directory.Build.props" />
<File Path="Directory.Packages.props" />
<File Path="dotnet-tools.json" />
<File Path="global.json" />
<File Path="readme.md" />
</Folder>
Expand Down
13 changes: 13 additions & 0 deletions dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"version": 1,
"isRoot": true,
"tools": {
"dotnet-validate": {
Comment thread
viceroypenguin marked this conversation as resolved.
"version": "0.0.1-preview.582",
"commands": [
"dotnet-validate"
],
"rollForward": true
}
}
}
2 changes: 0 additions & 2 deletions src/Immediate.Cache.Analyzers/Immediate.Cache.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="DotNet.ReproducibleBuilds" PrivateAssets="All" />
<PackageReference Include="Microsoft.Bcl.HashCode" />
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" PrivateAssets="All" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" />
<PackageReference Include="MinVer" PrivateAssets="all" />
</ItemGroup>

</Project>
12 changes: 7 additions & 5 deletions src/Immediate.Cache.Shared/Immediate.Cache.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,14 @@
<RootNamespace>Immediate.Cache</RootNamespace>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'net11.0'">
<Features>runtime-async=on</Features>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="DotNet.ReproducibleBuilds" PrivateAssets="All" />
<PackageReference Include="Immediate.Handlers" />
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="MinVer" PrivateAssets="all" />
<PackageReference Include="Immediate.Handlers" />
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
</ItemGroup>

</Project>
2 changes: 0 additions & 2 deletions src/Immediate.Cache/Immediate.Cache.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="DotNet.ReproducibleBuilds" PrivateAssets="All" />
<PackageReference Include="Immediate.Handlers" />
<PackageReference Include="Microsoft.Extensions.Caching.Abstractions" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="MinVer" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
Expand Down