Skip to content

feat(button): update button topics - #491

Open
Hristo313 wants to merge 24 commits into
vnextfrom
hhristov/update-button-topics
Open

feat(button): update button topics#491
Hristo313 wants to merge 24 commits into
vnextfrom
hhristov/update-button-topics

Conversation

@Hristo313

@Hristo313 Hristo313 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Closes #490

Update the button xplat topics

Also updated the samples:
Angular -> IgniteUI/igniteui-angular-samples#4019
React -> IgniteUI/igniteui-react-examples#1097
WC -> IgniteUI/igniteui-wc-examples#1244
Blazor -> IgniteUI/igniteui-blazor-examples#1297

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in the topic content when it has a valuable update, is new, or is considered preview / beta
  • link to other topics using ./page.mdx or ../relative/path.mdx (.mdx extension required)
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check if links function by running the check-api/mdx npm commands
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo
  • add or update meaningful llms.description metadata and run npm run check:llms-metadata


  • do not resolve requested changes (leave that to the reviewer)

@Hristo313 Hristo313 changed the title feat(button): update the topics content feat(button): update button topics Aug 14, 2026
@DiLazarova

Copy link
Copy Markdown
Contributor

Button Topic Review

Layout Template Section

For this layout example

Screenshot 2026-08-24 at 12 01 32

use the one we have in our design documentation to show the button with and without the icon

Screenshot 2026-08-24 at 12 03 18

instead of contained button variant, please use "Outlined".

For the Size section please use the example from the Design File in Figma: Figma File

Screenshot 2026-08-24 at 12 08 36

For Style Parts Section please check again the hover states to have a good contrast:
Screenshot 2026-08-24 at 12 10 03
Screenshot 2026-08-24 at 12 12 07

@IMinchev64 IMinchev64 removed the ❌ status: awaiting-test PRs awaiting manual verification label Aug 28, 2026
@IMinchev64 IMinchev64 added the ✅ status: verified Applies to PRs that have passed manual verification label Aug 28, 2026

### Prerequisites and Version Compatibility

Use a supported version of the {ProductName} package for your target framework. Keep the framework package, the Button package, and the theme package on the same release version. The examples below identify the framework and package used by each code block so that the snippets remain self-contained when read without the surrounding page context.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no button package, also the theme package has a different release cadence . A WC release will depend on a certain igniteui-theming version and won't work well without an update (same for the other platforms), but generally speaking since the theming package is a dep, the user doesn't really have to do anything to have them . I am not sold on the value this section provides tbh.

<PlatformBlock for="WebComponents">

First, you need to install the {ProductName} by running the following command:
For Web Components using the **{PackageWebComponents}** package, install the package:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The react and wc sections can be combined as there is a {} template token for the react package too.

npm install igniteui-angular
```

Then import the Button directive:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are talking about importing the directive but import the module which is a deprecated thing for backwards compatibility for people using modules instead of stand-alone. We don't want to do that, just import the directive.


</PlatformBlock>

<PlatformBlock for="React,WebComponents,Blazor">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erm, shouldn't we be using the platform-specific wrapper element - igrButton, igbButton etc?


### Interaction States

In Figma the Enabled buttons support **Idle**, Hover, Focused and Focused & Hover states which can be switched between by changing the `State` property. In code, these interaction states are provided by the platform Button component and should preserve a visible focus indicator for keyboard users.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here only Idle is bolded, while the other states are not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

button doc-redesign status: ✔️ by-design ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update button topics

4 participants