feat(button): update button topics - #491
Conversation
…niteUI/igniteui-documentation into hhristov/update-button-topics
Button Topic ReviewLayout Template Section For this layout example
use the one we have in our design documentation to show the button with and without the icon
instead of contained button variant, please use "Outlined". For the Size section please use the example from the Design File in Figma: Figma File
For Style Parts Section please check again the hover states to have a good contrast: |
|
|
||
| ### Prerequisites and Version Compatibility | ||
|
|
||
| Use a supported version of the {ProductName} package for your target framework. Keep the framework package, the Button package, and the theme package on the same release version. The examples below identify the framework and package used by each code block so that the snippets remain self-contained when read without the surrounding page context. |
There was a problem hiding this comment.
there is no button package, also the theme package has a different release cadence . A WC release will depend on a certain igniteui-theming version and won't work well without an update (same for the other platforms), but generally speaking since the theming package is a dep, the user doesn't really have to do anything to have them . I am not sold on the value this section provides tbh.
| <PlatformBlock for="WebComponents"> | ||
|
|
||
| First, you need to install the {ProductName} by running the following command: | ||
| For Web Components using the **{PackageWebComponents}** package, install the package: |
There was a problem hiding this comment.
The react and wc sections can be combined as there is a {} template token for the react package too.
| npm install igniteui-angular | ||
| ``` | ||
|
|
||
| Then import the Button directive: |
There was a problem hiding this comment.
You are talking about importing the directive but import the module which is a deprecated thing for backwards compatibility for people using modules instead of stand-alone. We don't want to do that, just import the directive.
|
|
||
| </PlatformBlock> | ||
|
|
||
| <PlatformBlock for="React,WebComponents,Blazor"> |
There was a problem hiding this comment.
erm, shouldn't we be using the platform-specific wrapper element - igrButton, igbButton etc?
|
|
||
| ### Interaction States | ||
|
|
||
| In Figma the Enabled buttons support **Idle**, Hover, Focused and Focused & Hover states which can be switched between by changing the `State` property. In code, these interaction states are provided by the platform Button component and should preserve a visible focus indicator for keyboard users. |
There was a problem hiding this comment.
here only Idle is bolded, while the other states are not





Closes #490
Update the button xplat topics
Also updated the samples:
Angular -> IgniteUI/igniteui-angular-samples#4019
React -> IgniteUI/igniteui-react-examples#1097
WC -> IgniteUI/igniteui-wc-examples#1244
Blazor -> IgniteUI/igniteui-blazor-examples#1297
Checklist:
preview/beta./page.mdxor../relative/path.mdx(.mdxextension required)IgxSelectComponent,<igx-combo>code blocksfor the names of classes / tags / propertiescode blockscheck-api/mdxnpm commandsllms.descriptionmetadata and runnpm run check:llms-metadata