style(grid): add missed animation import from theming - #17572
Merged
Conversation
mddragnev
added
grid: row-adding
grid
version: 22.2.x
❌ status: awaiting-test
simeonoff
approved these changes
Sep 3, 2026
simeonoff
enabled auto-merge (squash)
September 3, 2026 13:43
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is minimal, consistent with existing theming patterns (e.g., registering animation keyframes inside layer(base)), and directly supports a pre-existing animation: scale-in-ver-center ... usage in the same file.
Pull request overview
This PR restores a missing Sass animations import in the Ignite UI for Angular Grid base theme and registers the required animation keyframes, addressing an omission introduced during the scoped-styles refactor.
Changes:
- Added
@use 'igniteui-theming/sass/animations' as *;to the grid base theme. - Registered the
scale-in-ver-centeranimation via@include scale-in-ver-center();within the base layer so it’s available whereanimation: scale-in-ver-center ...is used.
File summaries
| File | Description |
|---|---|
| projects/igniteui-angular/grids/themes/_base.scss | Imports theming animations and includes the scale-in-ver-center keyframes used by the grid’s row add animation styling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17569
Description
Adding back animation from
igniteui-themingbecause it was missed when refactored the grid to scoped stylesMotivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)