fix(i18n): Fix setting partial resources not filling the rest per component. - #17541
Open
skrustev wants to merge 5 commits into
Open
fix(i18n): Fix setting partial resources not filling the rest per component.#17541skrustev wants to merge 5 commits into
skrustev wants to merge 5 commits into
Conversation
skrustev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in per-component i18n customization where providing partial resourceStrings caused unspecified strings to lose their default values (and/or not reflect later global i18n updates). The change standardizes the pattern across multiple components to keep a merged “defaults + overrides” resource object.
Changes:
- Update multiple components to return merged resource strings (defaults + per-component overrides) instead of returning only the override object.
- Ensure components recompute merged resources when global i18n changes (or when locale-based resources are refreshed).
- Add unit tests across affected components to validate partial overrides and global i18n updates.
Reviewed changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/igniteui-angular/tree/src/tree/tree.spec.ts | Adds tests validating merged tree node resource strings and reaction to global i18n changes. |
| projects/igniteui-angular/tree/src/tree/tree-node/tree-node.component.ts | Updates tree node resourceStrings handling to return merged defaults + overrides. |
| projects/igniteui-angular/time-picker/src/time-picker/time-picker.component.ts | Updates time picker resourceStrings handling to return merged defaults + overrides and refresh on resource updates. |
| projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.ts | Updates query builder resourceStrings handling to return merged defaults + overrides. |
| projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.spec.ts | Adds tests validating merged query builder resource strings and reaction to global i18n changes. |
| projects/igniteui-angular/query-builder/src/query-builder/query-builder-tree.component.ts | Refactors resource refresh logic and updates query builder tree resourceStrings merging behavior. |
| projects/igniteui-angular/query-builder/src/query-builder/query-builder-header.component.ts | Updates query builder header resourceStrings handling to return merged defaults + overrides. |
| projects/igniteui-angular/paginator/src/paginator/paginator.component.ts | Updates paginator resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/paginator/src/paginator/paginator.component.spec.ts | Adds paginator test validating non-overridden strings update on global i18n change. |
| projects/igniteui-angular/list/src/list/list.component.ts | Updates list resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/list/src/list/list.component.spec.ts | Adds list tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/input-group/src/input-group/input-group.component.ts | Updates input group resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/input-group/src/input-group/input-group.component.spec.ts | Adds input group tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/grids/grid/src/grid.component.spec.ts | Adds grid tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Updates grid base directive resourceStrings handling to return merged defaults + overrides; adds resource refresh helper. |
| projects/igniteui-angular/grids/core/src/pivot-grid-dimensions.ts | Updates pivot date dimension resourceStrings handling to return merged defaults + overrides. |
| projects/igniteui-angular/date-picker/src/date-range-picker/date-range-picker.component.ts | Updates date range picker resourceStrings handling to return merged defaults + overrides and refresh on resource updates. |
| projects/igniteui-angular/date-picker/src/date-range-picker/date-range-picker.component.spec.ts | Adds date range picker tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/combo/src/combo/combo.component.spec.ts | Adds combo tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/combo/src/combo/combo.common.ts | Updates combo base directive resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/chips/src/chips/chip.spec.ts | Adds chip tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/chips/src/chips/chip.component.ts | Updates chip resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/carousel/src/carousel/carousel.component.ts | Updates carousel resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/carousel/src/carousel/carousel.component.spec.ts | Adds carousel tests validating partial overrides and global i18n update behavior. |
| projects/igniteui-angular/calendar/src/calendar/calendar-base.ts | Updates calendar resourceStrings handling to return merged defaults + overrides; refactors resource refresh helper. |
| projects/igniteui-angular/banner/src/banner/banner.component.ts | Updates banner resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/banner/src/banner/banner.component.spec.ts | Adds banner tests validating behavior with/without custom strings under global i18n changes. |
| projects/igniteui-angular/action-strip/src/action-strip/action-strip.component.ts | Updates action strip resourceStrings handling to return merged defaults + overrides and refresh on resource changes. |
| projects/igniteui-angular/action-strip/src/action-strip/action-strip.component.spec.ts | Adds action strip tests validating preservation of custom strings under global i18n changes. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
skrustev
force-pushed
the
skrastev/fix-17540-master
branch
from
August 27, 2026 07:53
129ef9b to
9b975c1
Compare
mddragnev
added
💥 status: in-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17540
Description
Fix setting partial custom resources per component returning partial resources as well when getting them using the
resourceStringproperty instead of getting merged with the default ones.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)