fix(security): replace MD5 with SHA-256 for appstore workdir hashing - #214
Open
ford220102 wants to merge 2 commits into
Open
ford220102 wants to merge 2 commits into
ford220102 wants to merge 2 commits into
Conversation
Resolves SonarCloud security hotspot go:S4790 (weak hash algorithm). MD5 was used in WorkDir() only to derive a cache directory name from the appstore URL path - not for any security-sensitive purpose - but using a weak hash still triggers static analysis warnings. Switched to SHA-256 to close the hotspot with no functional changes.
Resolves SonarCloud reliability bug (http-resource-leak, L83). http.Head() response body was never closed on the success path, leaking the underlying connection. Added defer res.Body.Close() immediately after the error check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SonarCloud security hotspot go:S4790 (weak hash algorithm).
MD5 was used in WorkDir() only to derive a cache directory name from the appstore URL path - not for any security-sensitive purpose - but using a weak hash still triggers static analysis warnings. Switched to SHA-256 to close the hotspot with no functional changes.