feat(tts): desktop Kokoro/Piper TTS v2 + user-editable Python path#232
Draft
anishgoyal1108 wants to merge 1 commit into
Draft
feat(tts): desktop Kokoro/Piper TTS v2 + user-editable Python path#232anishgoyal1108 wants to merge 1 commit into
anishgoyal1108 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ython path Forward-ports the v2 desktop TTS engine work onto current upstream: - DesktopTTSEngineFactory: lazy createKokoroEngine() (gated on kokoroAvailable) + DesktopKokoroTTSEngineV2 wrapper delegating synthesis to KokoroTTSAdapter, with a per-(utterance,voice,speed) audio cache and bounded parallel pre-synthesis (respects the shared TTS-performance setting). - TTSController: persist + restore the selected EngineType across launches (persistedEngineType / saveEngineType). - DesktopTTSService, TTSModule / TTSEngine / TTSState / TTSNotificationUseCase, TTSV2ScreenSpec, TTSStateAdapter, TTSEngineSettingsScreen, AndroidTTSEngineFactory. - AppPreferences: kokoroAvailable, selectedTTSEngine, and a NEW user-editable kokoroPythonPath() override. - KokoroTTSEngine: honour kokoroPythonPath before auto-discovery so users with a pyenv/conda/venv/system interpreter can point Kokoro at it from Settings. Conflicts vs upstream's TTS refactors resolved (kept their debug log levels, preserved the persisted-engine-type hydration).
488b981 to
e92748d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forward-ports the desktop v2 Kokoro/Piper TTS engine work and adds a
user-editable Python-interpreter override.
DesktopTTSEngineFactory: lazycreateKokoroEngine()(gated onkokoroAvailable)DesktopKokoroTTSEngineV2wrapper that delegates synthesis toKokoroTTSAdapter, with a per-(utterance, voice, speed)audio cache and boundedparallel pre-synthesis (respects the shared TTS-performance setting).
TTSController: persist + restore the selectedEngineTypeacross launches(
persistedEngineType/saveEngineType).DesktopTTSService,TTSModule/TTSEngine/TTSState/TTSNotificationUseCase,TTSV2ScreenSpec,TTSStateAdapter,TTSEngineSettingsScreen,AndroidTTSEngineFactory.AppPreferences:kokoroAvailable,selectedTTSEngine, and a newkokoroPythonPathoverride.KokoroTTSEngine: honourkokoroPythonPathbefore auto-discovery, so users whoseinterpreter lives somewhere non-standard (pyenv / conda / venv / system package)
can point Kokoro at it.
Type of Change
Testing
kokoroPythonPathto a specific interpreter is honouredAdditional Notes
Resolved against upstream's TTS refactors: kept upstream's
debuglog levels whilepreserving the new persisted-engine-type hydration. Outstanding: a Settings text
field to edit
kokoroPythonPathfrom the UI (the pref + engine plumbing are done).