feat(artifacts): --artifacts generation in INDEX + ARTIFACT stages#2262
Open
pirhoo wants to merge 19 commits into
Open
feat(artifacts): --artifacts generation in INDEX + ARTIFACT stages#2262pirhoo wants to merge 19 commits into
pirhoo wants to merge 19 commits into
Conversation
…acts on --artifactDir
…ed raw bytes, resolve project consistently
…uard before COMPLETE
…atch --ocr convention)
…ctor (avoid requeue poison-loop) Move --artifacts validation and the ManifestRecorder/embedOutput wiring out of IndexTask's constructor and into call(). Reflectively-constructed tasks that throw from their constructor become a requeue-forever NackException; deferring the check to call() turns a bad --artifacts config into a clean task error instead. Introduce ArtifactStages.artifactProjectRoot as the shared entry point for this resolution, used from IndexTask.call().
…ages (INDEX+ARTIFACT parity) ArtifactTask now resolves its project name and force flag through the same ArtifactStages helper as IndexTask, instead of its own defaultProject-only lookup and separate force parse. Keeps the two stages from drifting on how they resolve a project name or the force flag.
…d types are not silent Make ManifestRecorder's RAW-only scope explicit: the class javadoc now states that INDEX-time recording only records the artifact types extract-lib materializes during the streaming parse (RAW today), and the constructor logs once when a selection includes other types so that it's clear they are deferred to the ARTIFACT stage rather than silently dropped.
… fully-qualifying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in per-document artifact generation (
raw), gated by--artifacts, on both CLI surfaces and both the INDEX and ARTIFACT stages. Closes #2225.--artifacts/--artifactsForceon the JOpt and picocli CLI surfacesManifestRecorder, wired fromElasticsearchSpewer--artifactsrequires--artifactDirRawArtifact.entryFor,ArtifactProducer.entryIsCurrent,ArtifactRegistry.withDefaults, andArtifactStagesproject/force resolution so INDEX and ARTIFACT stay in parity