Skip to content

Strip the 'v' from the published version#645

Merged
cb1kenobi merged 1 commit into
mainfrom
fix-publish-notification-version
Jun 11, 2026
Merged

Strip the 'v' from the published version#645
cb1kenobi merged 1 commit into
mainfrom
fix-publish-notification-version

Conversation

@cb1kenobi

Copy link
Copy Markdown
Member

I noticed the npm published notifications have an extra 'v' because it's using the tag name instead of the scrubbed version.

@cb1kenobi cb1kenobi requested a review from kriszyp as a code owner June 10, 2026 16:56
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Benchmark Results

get-sync.bench.ts

getSync() > random keys - small key size (100 records)

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 lmdb 1 24.21K ops/sec 41.31 39.97 2,146.216 0.138 121,042
🥈 rocksdb 2 12.30K ops/sec 81.27 78.72 22,652.777 0.899 61,523

getSync() > sequential keys - small key size (100 records)

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 lmdb 1 28.56K ops/sec 35.01 33.96 585.358 0.103 142,810
🥈 rocksdb 2 11.85K ops/sec 84.40 82.40 640.477 0.056 59,243

ranges.bench.ts

getRange() > small range (100 records, 50 range)

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 lmdb 1 25.74K ops/sec 38.85 35.66 1,932.283 0.295 128,704
🥈 rocksdb 2 17.61K ops/sec 56.79 50.21 2,246.107 0.153 88,040

realistic-load.bench.ts

Realistic write load with workers > write variable records with transaction log

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 rocksdb 1 482.47 ops/sec 2,072.65 106.345 33,574.853 9.24 965
🥈 lmdb 2 26.70 ops/sec 37,451.541 56.04 1,203,449.471 137.262 64.00

transaction-log.bench.ts

Transaction log > read 100 iterators while write log with 100 byte records

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 rocksdb 1 37.21K ops/sec 26.87 13.79 13,597.189 0.565 186,070
🥈 lmdb 2 440.70 ops/sec 2,269.121 423.341 8,129.757 1.14 2,205

Transaction log > read one entry from random position from log with 1000 100 byte records

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 rocksdb 1 767.67K ops/sec 1.30 1.12 2,780.64 0.142 3,838,334
🥈 lmdb 2 434.87K ops/sec 2.30 1.15 8,219.21 1.07 2,174,353

worker-put-sync.bench.ts

putSync() > random keys - small key size (100 records, 10 workers)

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 rocksdb 1 861.94 ops/sec 1,160.176 998.609 3,054.51 0.386 1,724
🥈 lmdb 2 1.15 ops/sec 866,063.499 835,131.784 912,461.016 2.03 10.00

worker-transaction-log.bench.ts

Transaction log with workers > write log with 100 byte records

Implementation Rank Operations/sec Mean (ms) Min (ms) Max (ms) RME (%) Samples
🥇 rocksdb 1 21.27K ops/sec 47.01 30.50 426.899 0.494 42,547
🥈 lmdb 2 813.23 ops/sec 1,229.671 41.95 14,255.545 5.92 1,627

Results from commit 5e0044a

@cb1kenobi cb1kenobi merged commit d23040d into main Jun 11, 2026
23 checks passed
@cb1kenobi cb1kenobi deleted the fix-publish-notification-version branch June 11, 2026 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants