Skip to content

Default applications.moduleLoader to vm-current-context#338

Merged
kriszyp merged 1 commit into
mainfrom
kris/vm-current-context-default
Jun 11, 2026
Merged

Default applications.moduleLoader to vm-current-context#338
kriszyp merged 1 commit into
mainfrom
kris/vm-current-context-default

Conversation

@kriszyp

@kriszyp kriszyp commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

Update the harper-pro shipped default applications.moduleLoader from vm to vm-current-context in static/defaultConfig.yaml, matching the core change in HarperFast/harper#1248.

Purpose

vm-current-context runs the application VM loader in Harper's own context so applications share JavaScript intrinsics, avoiding cross-realm instanceof/identity-check failures at the application/Harper boundary. vm mode (separate intrinsics) remains available for anyone who needs it.

Where to look

  • Config-only change; the behavioral implementation lives in core (#1248).
  • This PR intentionally does not bump the core submodule pointer — the core default flip lands via #1248 against core main first.

Generated with assistance from Claude (Opus 4.7); reviewed by Kris.

Match the core default flip: applications now load in Harper's own
context by default, sharing JavaScript intrinsics. This avoids the
cross-realm compatibility problems (instanceof and other identity
checks failing across the application/Harper boundary) that separate
per-application intrinsics can cause. Scope-specific values remain
available via `import ... from 'harper'` / `require('harper')`.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@kriszyp kriszyp requested a review from Ethan-Arrowood June 11, 2026 04:55
@claude

claude Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Reviewed; one potential blocker found.

Correctness: vm-current-context may not be supported by the currently pinned core commit

static/defaultConfig.yaml now advertises moduleLoader: vm-current-context as the default, but the core submodule pointer is unchanged at 3025d37. If that core commit does not recognize vm-current-context, new installs using this config template will either fail to start or silently fall back to vm — the opposite of the intended change.

The PR body states "the core default flip lands via #1248 against core main first", but no submodule bump is included here. This PR should not merge until a companion commit bumps the core submodule pointer to a commit that includes vm-current-context support, or alternatively the submodule bump should be added to this PR.

@kriszyp kriszyp marked this pull request as ready for review June 11, 2026 05:11
@kriszyp kriszyp requested a review from a team as a code owner June 11, 2026 05:11
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@kriszyp kriszyp enabled auto-merge (squash) June 11, 2026 15:20
@kriszyp kriszyp merged commit ea57d41 into main Jun 11, 2026
26 checks passed
@kriszyp kriszyp deleted the kris/vm-current-context-default branch June 11, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants