fix(caching-guide): correct jokeAPI.get() signature in complete example#521
Merged
Conversation
The 'Putting It All Together' example used `async get()` with `this.getId()` which throws at runtime. The correct signature is `async get(id)` — consistent with the earlier 'Wrapping an External Data Source' section and the working caching-guide-example repo. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-521 This preview will update automatically when you push new commits. |
cb1kenobi
approved these changes
Jun 9, 2026
Ethan-Arrowood
approved these changes
Jun 11, 2026
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async get()withthis.getId()inside the body, which throwsTypeError: this.getId is not a functionat runtimeasync get(id)—idis passed as a parameter by Harper'ssourcedFrommachinery, not via a method onthiscaching-guide-examplerepoTest plan
GET /JokeCache/1returns a joke (not a 500)caching-guide-examplemainbranch🤖 Generated with Claude Code — fix verified by running the full caching guide locally (all four scenarios: miss, cached, 304, no-cache, invalidate).