Skip to content

Skip initial monster filtering for custom resources#345

Merged
Lakeyzer merged 1 commit into
developfrom
feature/no_monster_list_demo_encounter_builder
Jun 26, 2026
Merged

Skip initial monster filtering for custom resources#345
Lakeyzer merged 1 commit into
developfrom
feature/no_monster_list_demo_encounter_builder

Conversation

@Lakeyzer

Copy link
Copy Markdown
Collaborator

No description provided.

@Lakeyzer Lakeyzer requested a review from HarmlessHarm June 26, 2026 12:10
@Lakeyzer Lakeyzer added the bug Something isn't working label Jun 26, 2026
@Lakeyzer Lakeyzer merged commit eb18fcf into develop Jun 26, 2026
4 checks passed
@Lakeyzer Lakeyzer deleted the feature/no_monster_list_demo_encounter_builder branch June 26, 2026 12:25
@sonarqubecloud

Copy link
Copy Markdown

HarmlessHarm pushed a commit that referenced this pull request Jul 7, 2026
Brings in NPC groups, campaign view refactor (#341), DM screen splitter
persistence (#339), Set Initiative NPC button (#344), and monster filter
changes (#345), re-expressed in Vue 3 syntax where main's code still
used Vue 2 patterns:

- slot="x" attributes -> v-slot templates (NpcGroupManager, BasicInfo,
  Npcs, Entities dialogs)
- $set/$delete/Vue.set/Vue.delete -> direct assignment (npcGroups and
  npcs store modules, hk-filter, Entities, BasicInfo)
- vue-snotify -> Quasar notify utils (NpcGroupManager, Entities, Npcs)
- vee-validate v3 slot props -> v4 errorMessage API (BasicInfo)
- QTable :data -> :rows; () => import() -> defineAsyncComponent
- process.browser -> typeof window guard in browserDetect (app failed
  to boot server- and client-side otherwise)
- adopted main's boot/prototypes.js (server-enabled for SSR)

Additionally fixes a latent Quasar v2 event-contract gap the merge
review surfaced: 101 @input handlers and 43 :value bindings on Quasar
form components renamed to @update:model-value / :model-value (Quasar
v2 components no longer emit input or read value; the handlers were
dead and several bindings one-way only).

Verified: SPA + SSR builds pass; headless audit of 10 routes renders
with zero Vue warnings.

https://claude.ai/code/session_013pNZHMppjJ2iGVjxjHKkpQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants