[Enhancement] Improved Roll#6604
Conversation
|
this seems questionable, what's the motivation? |
its basically twilight princess rolling, which some may feel feels better |
|
It has been requested aswell on the hm64 discord sometimes |
| if ((this->skelAnime.curFrame >= 15.0f) && CHECK_BTN_ALL(sControlInput->press.button, BTN_A) && | ||
| (sFloorType != 7) && GameInteractor_Should(VB_PLAYER_ROLL_CHAIN, false, this, play)) { | ||
| Player_SetupRoll(this, play); | ||
| return; | ||
| } |
There was a problem hiding this comment.
this seems unideal for hooking, how important is roll chaining to experience?
There was a problem hiding this comment.
I dont understand your question unfortunatly.
There was a problem hiding this comment.
If were talking about if its a must have then its very subjective. This kind of thing exist as a mod for MM Recomp and Indigo is doing this kind of rollstyle completely
There was a problem hiding this comment.
Okay. My main complaint here is this logic should live in hook, not decomp code
There was a problem hiding this comment.
Oh. I can take a look at it tomorrow.
There was a problem hiding this comment.
Moved logic to improvedroll.cpp and make it a oneline hook in source
|
I've been waiting for this forever. I hope it gets merged. |
This PR adds an option to have improved rolling capabilities.
It is 2 stage cvar.
First cvar enables it so player can reroll during a roll by pressing A at the end of a roll window.
Second cvar enables the ability to steer during rolling. Reason why this is separated is that roll steering interferes with glitch setups during z-targeting. I have added a z target protection so steering cant happen if Z is held. Im still feeling it should be a separate cvar. I have tested and succesfully done the King zora skip clip as child with this enabled.
Video_2026-05-09_14-33-25_discord.mp4
Build Artifacts