Skip to content

[Enhancement] Improved Roll#6604

Open
Jepvid wants to merge 6 commits into
HarbourMasters:developfrom
Jepvid:ImprovedRoll
Open

[Enhancement] Improved Roll#6604
Jepvid wants to merge 6 commits into
HarbourMasters:developfrom
Jepvid:ImprovedRoll

Conversation

@Jepvid
Copy link
Copy Markdown
Contributor

@Jepvid Jepvid commented May 9, 2026

This PR adds an option to have improved rolling capabilities.

It is 2 stage cvar.

First cvar enables it so player can reroll during a roll by pressing A at the end of a roll window.

Second cvar enables the ability to steer during rolling. Reason why this is separated is that roll steering interferes with glitch setups during z-targeting. I have added a z target protection so steering cant happen if Z is held. Im still feeling it should be a separate cvar. I have tested and succesfully done the King zora skip clip as child with this enabled.

Video_2026-05-09_14-33-25_discord.mp4

Build Artifacts

Comment thread soh/soh/Enhancements/game-interactor/vanilla-behavior/GIVanillaBehavior.h Outdated
Comment thread soh/soh/Enhancements/TimeSavers/ImprovedRoll.cpp
@serprex
Copy link
Copy Markdown
Member

serprex commented May 9, 2026

this seems questionable, what's the motivation?

@Jameriquiah
Copy link
Copy Markdown
Member

this seems questionable, what's the motivation?

its basically twilight princess rolling, which some may feel feels better

@Jepvid
Copy link
Copy Markdown
Contributor Author

Jepvid commented May 9, 2026

It has been requested aswell on the hm64 discord sometimes

Comment on lines +9856 to +9860
if ((this->skelAnime.curFrame >= 15.0f) && CHECK_BTN_ALL(sControlInput->press.button, BTN_A) &&
(sFloorType != 7) && GameInteractor_Should(VB_PLAYER_ROLL_CHAIN, false, this, play)) {
Player_SetupRoll(this, play);
return;
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unideal for hooking, how important is roll chaining to experience?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand your question unfortunatly.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If were talking about if its a must have then its very subjective. This kind of thing exist as a mod for MM Recomp and Indigo is doing this kind of rollstyle completely

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. My main complaint here is this logic should live in hook, not decomp code

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I can take a look at it tomorrow.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved logic to improvedroll.cpp and make it a oneline hook in source

@LuigiXHero
Copy link
Copy Markdown
Contributor

I've been waiting for this forever. I hope it gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants