Compile z_bgcheck.c on arm64 macOS with -ffp-contract=off#6584
Open
agamache wants to merge 1 commit into
Open
Conversation
serprex
approved these changes
May 4, 2026
Member
|
thinking more, we can apply this flag globally |
Contributor
Author
|
I know audio stuttering has been an issue on the macOS version in the past, but I can try running a version with the flag applied globally to get a quick idea of any effects on performance when I get home from work this evening |
Member
|
mac stuttering was caused by calling |
agamache
force-pushed
the
nofpcontract-bgcheck
branch
from
1142edf to
8369c56
Compare
Contributor
Author
|
I just tested a build with the flag applied globally in the top-level CMakeLists.txt and didn't observe any performance regressions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling for arm64 and x86_64, compiler optimizations for contracting floating point operations to fused-multiply-add instructions behave differently, producing code that is not IEEE 754 compliant on arm64 macOS. In some specific scenarios, these inconsistencies result in different behavior from the base game, such as not being able to enter Bottom of the Well as adult using a weirdshot.
This pull request adds the compiler flag "-ffp-contract=off" only on arm64 macOS to disable these optimizations in z_bgcheck.c, restoring IEEE 754 compliant behavior for those specific interactions.
Build Artifacts