[Enhancement] Restore Saria's gesture animation in her house#6569
Open
JordanLongstaff wants to merge 4 commits into
Open
[Enhancement] Restore Saria's gesture animation in her house#6569JordanLongstaff wants to merge 4 commits into
JordanLongstaff wants to merge 4 commits into
Conversation
JordanLongstaff
changed the title
Restores Saria's Friends Forever gesture option with tooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize that this is very minor, but I noticed that this animation was set up in the code, where supposedly, Saria would have this conversation and make a gesture if you talked to her at some point in the forest, if you came back after leaving but before meeting Zelda. Since she got moved into her house at that point, that rendered the animation inactive. I added a mod option that restores it.
The tricky thing was making sure that she doesn't just become frozen after the animation is done, so she needs to be reset to her normal animation at that point. I've attached two clips to show that it works regardless of whether you're still talking to her or not.
saria-anim-while-talking.mp4
saria-anim-after-talking.mp4
Build Artifacts