Fix shell command handling for paths with spaces and metacharacters - #22
Open
Gustavo-Harnisch wants to merge 1 commit into
Open
Fix shell command handling for paths with spaces and metacharacters#22Gustavo-Harnisch wants to merge 1 commit into
Gustavo-Harnisch wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix shell command handling when Polyman projects or source files are located in paths containing spaces or shell metacharacters.
Problem
Polyman constructed shell commands by interpolating paths and arguments without quoting them.
For example, a project located at:
could fail with:
The shell interpreted characters such as spaces, parentheses, and apostrophes before the arguments reached the compiler or executable.
Changes
quoteShellArgumenthelper.testlib.h.Tests
Added regression coverage for:
), and an apostrophe.Validation
npm run format:checknpm run lintnpm run buildnpm test -- --runResult:
The original C++ reproduction now compiles and runs successfully.
Platform note
The POSIX behavior is covered by unit and integration tests. The Windows quoting branch was reviewed statically but has not yet been exercised in a Windows environment.