Skip to content

Actions update and new init script#731

Merged
mambelli merged 3 commits into
HEPCloud:masterfrom
mambelli:new_init_script
Jun 10, 2026
Merged

Actions update and new init script#731
mambelli merged 3 commits into
HEPCloud:masterfrom
mambelli:new_init_script

Conversation

@mambelli

@mambelli mambelli commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Actions update and new init script

  • GH actions update
  • Init script with root executed pre-script

@mambelli mambelli requested a review from namrathaurs June 9, 2026 17:11
@mambelli mambelli self-assigned this Jun 9, 2026
@mambelli mambelli force-pushed the new_init_script branch 4 times, most recently from 3a1707f to 813a354 Compare June 10, 2026 03:42
Updated Pandas to v2 (v1.x is not supported in Python 3.12)
Fixed failed unit test due to pandas v2 changes
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (b4951ee) to head (4c8f477).
⚠️ Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   93.62%   97.12%   +3.50%     
==========================================
  Files          51       51              
  Lines        3199     3199              
  Branches      393      393              
==========================================
+ Hits         2995     3107     +112     
+ Misses        166       56     -110     
+ Partials       38       36       -2     
Flag Coverage Δ
python-3.11 ?
python-3.12 97.12% <100.00%> (?)
python-3.9 93.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mambelli mambelli requested a review from vitodb June 10, 2026 04:09

@vitodb vitodb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

# Group = decisionengine
# ExecStartPre = +/usr/bin/decisionengine-init.sh
ExecStart = /usr/bin/decisionengine "$DE_OPTS"
## + in ExecStartPre/ExecStart should allow o run as root (process is executed with full privileges)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a typo in this comment:
allow o run -> allow to run

@mambelli mambelli merged commit c9949bb into HEPCloud:master Jun 10, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants