Error when trying to load a map at runtime in a Compiled Project

[Adrihfu]

Every PackedScene.instantiate reference that uses any edit_state different than 0, does not work outside of editor builds. (vmf_node.gd:271- prop_studio.gd:40)

Is this behaviour intended?

[H2xDev]

Hello! Could you provide the sample project to check the issue please?

[Adrihfu]

Sorry about the late response

sample_project_for_issue_94-_fail_runtime_map_import_on_compile.zip

The project includes a scene with ui to load a map in runtime, 2 scripts (ui and camera controls), a vmf (with brushes, displacement, func_detail's and prop_static's), a bunch of materials and models.

It doesn't include the export executable, you can use any godot 4 version to compile, i test it in 4.5 and 4.6.3.

Thanks

[H2xDev]

@Adrihfu could you check is this problem solved in PR #96 please?

[Adrihfu]

@H2xDev Is not solved.

Console:

ERROR: Edit state is only for editors, does not work without tools compiled.
   at: (scene/resources/packed_scene.cpp:2507)
   GDScript backtrace (most recent call first):
       [0] import_entities (res://addons/godotvmf/src/vmf_node.gd:271)
       [1] _custom_import_map (res://src/main.gd:59)
       [2] _on_button_load_pressed (res://src/main.gd:25)

vmf_node.gd line 271:

var node = tscn.instantiate(PackedScene.GEN_EDIT_STATE_MAIN_INHERITED);

Same implementation has in #96 prop_studio: Disable gen edit state for runtime mode

[H2xDev]

@Adrihfu updated the PR. It should work now

[Adrihfu]

Works as intended now @H2xDev Thanks

Before closing this issue I'm getting this log about generating lightmap UV2 on func_detail's,
althought I did disable it in Project Settings (godot_vmf/import/generate_lightmap_uv2)

ERROR: Parameter "array_mesh_lightmap_unwrap_callback" is null.
   at: lightmap_unwrap_cached (scene/resources/mesh.cpp:2084)
   GDScript backtrace (most recent call first):
       [0] _entity_setup (res://addons/godotvmf/entities/func_detail.gd:11)
       [1] _ready (res://addons/godotvmf/src/vmf_entity_node.gd:69)
       [2] push_entity_to_group (res://addons/godotvmf/src/vmf_node.gd:246)
       [3] import_entities (res://addons/godotvmf/src/vmf_node.gd:280)
       [4] _custom_import_map (res://src/main.gd:59)
       [5] _on_button_load_pressed (res://src/main.gd:25)

WARNING: [GodotVMF] func_detail 1132: lightmap_unwrap failed (3), skipping UV2
     at: push_warning (core/variant/variant_utility.cpp:1034)
     GDScript backtrace (most recent call first):
         [0] warn (res://addons/godotvmf/src/vmf_logger.gd:10)
         [1] _entity_setup (res://addons/godotvmf/entities/func_detail.gd:13)
         [2] _ready (res://addons/godotvmf/src/vmf_entity_node.gd:69)
         [3] push_entity_to_group (res://addons/godotvmf/src/vmf_node.gd:246)
         [4] import_entities (res://addons/godotvmf/src/vmf_node.gd:280)
         [5] _custom_import_map (res://src/main.gd:59)
         [6] _on_button_load_pressed (res://src/main.gd:25)

Maybe adding a check in func_detail.gd line 11 for the generate_lightmap_uv2 property?

	if VMFConfig.import.generate_lightmap_uv2:
		var unwrap_err = mesh.lightmap_unwrap(global_transform, config.import.lightmap_texel_size);
		if unwrap_err != OK:
			VMFLogger.warn("func_detail %s: lightmap_unwrap failed (%d), skipping UV2" % [entity.id, unwrap_err]);

[Adrihfu]

The problem of this issue was solved, so I'll close it