Skip to content

html: Live Monitor fixes, Power Button, Disk Image mounting#642

Open
TangoBravo64 wants to merge 4 commits into
GideonZ:masterfrom
TangoBravo64:webui_fixes
Open

html: Live Monitor fixes, Power Button, Disk Image mounting#642
TangoBravo64 wants to merge 4 commits into
GideonZ:masterfrom
TangoBravo64:webui_fixes

Conversation

@TangoBravo64

Copy link
Copy Markdown
Contributor

A number of smaller fixes and additions, split into smaller commits:

  • Live Monitor: addresses containing an "e" did not work (e.g. "m 1e0"), as the terminal interpreted these as decimal numbers written in "exponential form" (1E0 = 1, 1E3=1000, ...).
  • Adds "power off" option to the nav bar for supported boards (Ultimate 64 II)
  • Adds "firmware version" to the nav bar (read from /v1/info).
  • Remote player now accepts and mounts D64/D71/D81 files (always mounted in drive A).
  • Other smaller fixes.
poweroff livemonitor

Commands like "m 1E0" did not work as expected, as values with an "e" were
interpreted as decimal values in exponential notation (1e0 = 1, 1e1=10,
1e2=100) by the jquery.terminal module. Disabled "argument processing",
so all parameters are passed as strings (keeping hexadecimal values safe).

Also:
- Set option to allow resizing the BASCI editor window.
- Synchronize the upper/lower case setting, when browsers have
  cached the setting and the page is reloaded.
- Adds power off button (only shown for Ultimate 64-II).
- Adds firmware version  (read from /v1/info).
- Clean up of duplicated CSS rules.
- Disk images are always mounted to drive A.
@chrisgleissner

Copy link
Copy Markdown
Contributor

Hi @TangoBravo64 ,

thanks for having raised this PR.

Reading through your change list, it seems to me that these bug fixes and improvements would be really useful to have in the new firmware version. In particular the inability to view hex addresses containing an e seems quite a large bug to me, and it's great this is fixed in your PR based on your PR description.

I know that @GideonZ is currently working on 3.15 and merged a bunch of PRs into the test-merge branch.

If you are interested in getting this merged, it may be worth to redirect its merge target to test-merge (instead of master) and to also perform a final test, as a lot of changed have occurred in test-merge since you created this. I do not see anything that could result merge conflicts or clashes with your changes, but just to be on the safe side, it may be useful.

Also, once you are done with the tests, could you please update here which devices you tested it on, and how you tested it?

Thanks
Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants