Repository navigation
tests: the generated indexes and their generator are gone - #4564
Conversation
Ten generated files listed every test with its description (tests/README.md, utils/TESTS.md, modules/dasLLAMA/tests/TESTS.md and seven more), and check_tests_index failed a tree whose index was stale. Every change that adds, moves or describes a test rewrote one of them, so two branches touching tests conflicted there on every rebase. The files are deleted. utils/internal/test-audit keeps its audit and loses --readme, --verify and --index; the check_tests_index target, its place in the extended checks and preflight's tests-index gate go with them. The checklists, tests/ARCHITECTURE.md and the skills no longer name an index. A test's description stays required: the shape gate holds it, and dastest prints it under the FAIL line. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
8dc06f2 to
aad8da5
Compare
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change consistently removes generated test index artifacts and their CI/preflight enforcement while updating the remaining test-audit tooling, coverage tests, and related documentation/checklists to match, with no outstanding issues indicated in the review evidence.
No open issues 🎉
What changed in this PR
Removes the repository’s committed/generated test index markdown files and the tooling/CI gates that generated and verified them, relying instead on per-test description= metadata and on-demand test-audit reporting to avoid frequent merge conflicts.
Changes:
- Deleted generated test index files/README indexes across tests, modules, examples, and dastest.
- Simplified
utils/internal/test-auditby removing index generation/verification flags while keeping audit reporting. - Removed the
check_tests_indexCMake target and the related preflight/CI wiring, updating docs/checklists accordingly.
| File | Description |
|---|---|
| utils/REVIEW.md | Updates the utils review checklist to remove references to generated test indexes and their verification target. |
| utils/REVIEW.das | Removes the internal-reference exemption for utils/TESTS.md now that the file/index is gone. |
| utils/internal/test-audit/uncategorized_no_aot.das | Updates the test-audit test coverage to validate audit behavior without index generation/verification paths. |
| utils/internal/test-audit/main.das | Removes --readme, --verify, and --index CLI functionality and associated index rendering/diff logic, leaving audit-only behavior. |
| utils/internal/preflight/main.das | Removes the tests-index preflight gate and its registration/dispatch wiring. |
| utils/CMakeLists.txt | Deletes the check_tests_index custom target that validated generated test indexes. |
| tests/REVIEW.md | Updates the tests checklist to remove coupling to the removed check_tests_index gate. |
| tests/ARCHITECTURE.md | Removes references to the deleted tests index README and updates wording to reflect census/audit-based usage. |
| skills/internal/tests_in_repo.md | Updates contributor guidance to reflect that no generated test index is kept in-tree and to rely on test-audit output instead. |
| skills/internal/preflight.md | Removes documentation of the tests-index gate from the preflight guidance. |
| skills/internal/aot_testing.md | Removes steps that required updating the deleted tests index file when adding AOT tests. |
| modules/TESTS.md | Removes the generated modules test index markdown file. |
| modules/REVIEW.md | Updates the modules review checklist to remove references to generated indexes and their verification target. |
| modules/dasVulkan/tutorials/TESTS.md | Removes the generated dasVulkan tutorials test index markdown file. |
| modules/dasVulkan/tests/REVIEW.md | Updates the dasVulkan tests review checklist to remove references to generated test indexes/verification. |
| modules/dasVulkan/tests/README.md | Removes the generated dasVulkan tests index README file. |
| modules/dasLLVM/tests/TESTS.md | Removes the generated dasLLVM tests index markdown file. |
| modules/dasLLVM/tests/REVIEW.md | Updates the dasLLVM tests review checklist to remove references to the generated index and its verification. |
| modules/dasLLVM/tests/README.md | Updates prose documentation to remove mentions of the generated tests index file. |
| modules/dasLLAMA/tests/REVIEW_FILES.md | Updates the dasLLAMA tests review notes to drop references to check_tests_index/generated index gating. |
| modules/dasImgui/tests/TESTS.md | Removes the generated dasImgui tests index markdown file. |
| modules/dasImgui/tests/REVIEW.md | Updates the dasImgui tests review checklist to remove references to generated indexes and verification. |
| examples/games/TESTS.md | Removes the generated examples/games test index markdown file. |
| examples/games/REVIEW.md | Updates the examples/games review checklist to remove references to generated index verification. |
| dastest/tests/REVIEW.md | Updates the dastest tests review checklist to remove references to the generated index README and verification target. |
| dastest/tests/README.md | Removes the generated dastest tests index README file. |
| dastest/test_shape.das | Adjusts diagnostic wording to refer to the census/audit reader rather than an index generator. |
| dastest/README.md | Updates documentation for [test(description=...)] to reflect that descriptions are consumed by the census/audit tooling without generating an index. |
| CMakeLists.txt | Removes install/exclusion handling that existed specifically for generated TESTS.md artifacts. |
| CLAUDE.md | Updates the referenced checklist/skills row to remove expectations around maintaining a generated tests index file. |
| ci/CMakeLists.txt | Removes check_tests_index from the extended CI checks configuration. |
Review effort: Balanced
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a consistent cleanup that removes generated test index artifacts and their generator/verification wiring across code, CMake/CI, and documentation/checklists without any noted outstanding problems or unresolved references in the provided review evidence.
No open issues 🎉
Review effort: Balanced
Behavior change: the tree keeps no generated index of its tests. The ten index files, the generator that wrote them and the CI target that verified them are removed.
Why. Every change that adds, moves or describes a test rewrote one of the generated files, so any two branches that touch tests conflicted there on rebase - #4557 hit it twice in one rebase, #4537 and #4540 before it.
What changes.
tests/README.md,utils/TESTS.md,dastest/tests/README.md,modules/TESTS.md,examples/games/TESTS.md, and the indexes undermodules/dasLLVM/tests,modules/dasVulkan/tests,modules/dasVulkan/tutorials,modules/dasImgui/tests,modules/dasLLAMA/tests. The proseREADME.mdfiles of dasLLVM, dasImgui and dasLLAMA tests stay.utils/internal/test-audit/main.das:--readme,--verifyand--indexare gone; the audit (--files,--candidates,--tests-only, repeated--root) stays.utils/CMakeLists.txt,ci/CMakeLists.txt: thecheck_tests_indextarget and its place in the extended checks.utils/internal/preflight/main.das: thetests-indexgate.tests/,utils/,dastest/tests/,modules/,examples/games/, the dasLLVM, dasVulkan, dasImgui and dasLLAMA test folders),tests/ARCHITECTURE.md,skills/internal/tests_in_repo.md,skills/internal/aot_testing.md,skills/internal/preflight.md, theCLAUDE.mdrow.Unchanged. A
[test]still must carry adescription: the shape gate (dastest/test_shape.das) holds it and dastest prints it under the--- FAILline.Validation, not done
Validation
Windows, Release.
cmakere-configures with no reference to the removed target.utils/internal/test-audit/uncategorized_no_aot.das: passes, with the index arms removed and the audit arms kept (class counts, undescribed count,--tests-only, an installed package left out, several roots).utils/internal/preflight/tests: 33 passed;tests/dastest: 21 passed.review-md all: 37 gates, 0 red;tests/REVIEW.das,utils/REVIEW.das,dastest/tests/REVIEW.dasexit 0.dasfmt --verifyand lint over the five changed.dasfiles, the line-length gate, Markdown ASCII: clean.Not done
test-audit --filesprints every file with its counts, and a description is read in its file.