Repository navigation
ci: the windows 64 Debug nightly cell is gone - #4507
Merged
Merged
Conversation
An MSVC Debug interpreter sweep of tests/ takes most of an hour on the hosted runner, and the lane's `run_build || run_build_isolated` retry turns one missed watchdog into a four-hour job: #4495's merged lint project suite ran 1775 s as one ctest there, past dastest's 1200 s default, and the cell then spent the rest of the night in its isolated retry. The four other Debug cells (linux, linux_arm, darwin15, darwin26) cover the Debug-only interpreter paths per PR, as the win32 Debug cell's removal already relied on. With the cell gone, the raised sweep watchdogs belong to the sanitizer cells alone, and the `lint_project_*` ctest no longer needs its Windows Debug exemption. ci/test_ci_matrix.py's nightly-only list drops the one name; every other assertion stands. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Note
Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.
🟢 Approval recommended
The change is a straightforward CI-matrix maintenance update (removing a nightly-only Windows Debug lane) with corresponding test expectation and documentation adjustments, and the provided context indicates no active issues blocking approval.
No open issues 🎉
What changed in this PR
This pull request removes the Windows x64 Debug job from the nightly CI build matrix (leaving the per-PR matrix unchanged) and updates tests, CMake notes, and internal documentation to match the new nightly configuration.
Changes:
- Drop the nightly-only
windows-64-Debug-nonecell fromci/ci_matrix.py. - Update
ci/test_ci_matrix.pypinned expectations and “slow/raised watchdog budget” assertions to align with the reduced nightly matrix. - Remove remaining references/exemptions for the deleted lane in CMake and internal docs.
| File | Summary |
|---|---|
utils/CMakeLists.txt |
Removes the Windows Debug-specific exclusion for lint_project_* ctests now that the nightly lane is removed. |
tests/CMakeLists.txt |
Updates comments/documentation around sweep/watchdog budgets to no longer reference the removed Windows Debug nightly lane. |
skills/internal/preflight.md |
Updates internal CI/preflight documentation to stop naming the deleted nightly cell. |
ci/test_ci_matrix.py |
Updates matrix tests to remove the nightly Windows x64 Debug cell and adjust related assertions accordingly. |
ci/ci_matrix.py |
Removes the Windows x64 Debug nightly build cell and updates associated rationale/comments. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior change: the nightly matrix no longer runs a windows 64 Debug cell. The per-PR matrix is unchanged; the four other Debug cells keep covering the Debug-only interpreter paths.
Why. An MSVC Debug sweep of
tests/takes most of an hour on the hosted runner, and the lane'srun_build || run_build_isolatedretry turns one missed watchdog into a four-hour job. On #4495 the merged lint project suite ran 1775 s as one ctest there, past dastest's 1200 s default, and the cell then sat in its isolated retry for the rest of the night; master's own nightly the same day took 37 min, so the cell flips on any slow suite.What changes.
ci/ci_matrix.pydrops the cell; the raised sweep watchdogs (SLOW_SWEEP_BUDGETS) now name the sanitizer cells alone.ci/test_ci_matrix.py: the nightly-only cell list loses that one name and the half-speed assertion keys on sanitizers only. No assertion is dropped or loosened beyond the removed cell.utils/CMakeLists.txt: thelint_project_*ctest's Windows Debug exemption from utils, dastest/tests: suites merge by topic; lint exe; shape gate per root #4495 goes with the cell.tests/CMakeLists.txtandskills/internal/preflight.mdstop naming the cell.Where to look.
ci/ci_matrix.pybuild_cells,ci/test_ci_matrix.pyNIGHTLY_ONLY_BUILD.Validation and notes
Validation
python3 ci/test_ci_matrix.py: 27 tests pass;ci_matrix.py build_nightlylists 16 cells, windows 32 and 64 Release only.build_matrix.ymlandnightly.ymltake the matrix from the script.Not done
windowscells still have no Debug build at all; a Debug-only MSVC regression surfaces on a developer box, as it did before the nightly cell existed.