Skip to content

Resub Linking - Skip Those With Equivalent Submission Dates - #6040

Merged
jperson1 merged 2 commits into
mainfrom
jp/linking-skip-equal-submission-dates
Oct 20, 2026
Merged

jperson1 merged 2 commits into
mainfrom
jp/linking-skip-equal-submission-dates

Conversation

@jperson1

Copy link
Copy Markdown
Contributor

On linking, skip chains where the submission date is equal. Tags them for manual review, and omits them in the linking/unlinking actions.

Related tickets

  • N/A

Description of changes

  • When we generate the chains, we filter and sort a bit. This adds a quick annotation step that appends "skipped" to the report. "Y" if any of the reports in the chain have equivalent submission dates, and "N" otherwise.
  • The "skipped" tag is added to the CSV and Markdown exports
  • The "skipped" tag is taken into account in the undo_link_resubmissions command, since it's a new column in the CSV that identifies a row that we actually cannot unlink.

How to test

Switch to this branch, run normally. Have a go at linking a year, and verify that the new annotation doesn't break anything. If you use a dev data dump, this is sure to occur in lots of places.

python manage.py link_resubmissions --audit_year 2018 --email {YOUR_EMAIL} --noisy

Sample Outputs

image

*.md may include:

#### UEI GSA_MIGRATION - SKIPPED
| |  | ... resubmitted as |
| :-- | :-- | :-- |
{SO MUCH INFO}

*.csv may include:

chain_index,report_id,audit_year,fac_accepted_date,auditee_uei,auditee_ein,auditee_email,auditee_name,auditee_state,prior_submission_status,prior_resubmission_meta,skipped
{SO MUCH INFO},N
{SO MUCH INFO},Y

I've omitted a lot of the actual info since it may dilute the usefulness of search results in the future to include a bunch of report IDs and auditee names and whatnot.

… for manual review, and omits them in the linking/unlinking actions.
@jperson1
jperson1 requested a review from a team October 19, 2026 21:34
@jperson1 jperson1 self-assigned this Oct 19, 2026
Sometimes, we test things and neglect to undo them
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100% ✔
api 98% 86% ✔
api.serializers 97% 88% ✔
api.views 88% 96% ➖
audit 95% 80% ✔
audit.cross_validation 97% 87% ✔
audit.fixtures 84% 50% ❌
audit.formlib 94% 72% ✔
audit.intakelib 89% 83% ➖
audit.intakelib.checks 92% 86% ✔
audit.intakelib.common 98% 82% ✔
audit.intakelib.transforms 100% 95% ✔
audit.management.commands 78% 17% ❌
audit.migrations 100% 100% ✔
audit.models 91% 69% ✔
audit.templatetags 94% 83% ✔
audit.test_viewlib 100% 93% ✔
audit.viewlib 81% 78% ❌
audit.views 75% 54% ❌
census_historical_migration 99% 100% ✔
census_historical_migration.migrations 100% 100% ✔
census_historical_migration.sac_general_lib 92% 84% ✔
census_historical_migration.transforms 95% 90% ✔
census_historical_migration.workbooklib 70% 75% ❌
config 79% 31% ❌
curation 98% 92% ✔
curation.curationlib 91% 84% ✔
curation.management.commands 38% 31% ❌
curation.migrations 100% 100% ✔
dissemination 90% 70% ✔
dissemination.analytics 27% 0% ❌
dissemination.forms 80% 30% ❌
dissemination.migrations 98% 25% ✔
dissemination.models 100% 100% ✔
dissemination.report_generation 21% 0% ❌
dissemination.report_generation.excel 32% 0% ❌
dissemination.searchlib 61% 43% ❌
dissemination.templatetags 52% 6% ❌
dissemination.views 71% 51% ❌
djangooidc 53% 38% ❌
djangooidc.tests 100% 94% ✔
report_submission 99% 94% ✔
report_submission.migrations 100% 100% ✔
report_submission.templatetags 74% 100% ❌
report_submission.views 75% 57% ❌
support 94% 75% ✔
support.migrations 100% 100% ✔
support.models 72% 11% ❌
tools 98% 50% ✔
users 95% 86% ✔
users.fixtures 100% 83% ✔
users.management 100% 100% ✔
users.management.commands 100% 100% ✔
users.migrations 100% 100% ✔
Summary 89% (24581 / 27640) 70% (3070 / 4376) ➖

Minimum allowed line rate is 85%

@daryll daryll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
was able to test local.

@jperson1
jperson1 added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 07b35c8 Oct 20, 2026
16 checks passed
@jperson1
jperson1 deleted the jp/linking-skip-equal-submission-dates branch October 20, 2026 13:48

This branch was previously deployed

1 inactive deployment
testing — 146d5f28 Deployed Oct 19, 2026 by jperson1 via cypress-from-container / cypress-run #1651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants