Repository navigation
BUG] Fix generate resubmissions step in manage-local-data.bash - #6017
Merged
Merged
Conversation
…GSA-TTS/FAC into rm/update-generate-resubmission
…GSA-TTS/FAC into rm/update-generate-resubmission
phildominguez-gsa
requested changes
Oct 21, 2026
Co-authored-by: Phil Dominguez <142051477+phildominguez-gsa@users.noreply.github.com>
…GSA-TTS/FAC into rm/update-generate-resubmission
Contributor
Minimum allowed line rate is |
phildominguez-gsa
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tickets
#5997
Description of changes
check_resubmission_allowed()to querySingleAuditChecklistdirectly instead of relying on theGeneraldissemination table.check_legacy_resubmission_allowed()to simplify the logic and resolve the Flake8 complexity warning.How to test
Start the local FAC environment and load the sanitized data.
Navigate to
util/load_public_dissem_data/and runmanage_local_data.bash.Select option 4 - Generate fake resubmission dissemination data.
Select option 5 - Generate resubmissions, without running option 7 to re-disseminate all SAC records.
Verify that:
Generaldissemination table.Run option 5 again to verify the process can be repeated without errors.
Run the unit tests:
docker compose run --rm web python manage.py test audit.test_check_resubmission