fix(ui): align icon buttons and icon opacity with UIKit - #2902
Merged
Conversation
Align xs icon button corners and interaction surfaces, and add the standard 30px outlined circle with a 16px glyph while preserving existing defaults. Move reviewed monochrome artwork alpha to a public token controlled by icon slots. Preserve standalone and layered artwork opacity, apply trailing button icon contrast, and remove redundant product slot sizing without resizing Button. Update Design Lab combinations, component contracts, asset fingerprints and regression coverage, and regenerate the offline design-system stylesheet. Validation: design-system:check, check:web, and nine session layout tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Bug fix / UI/UX
Areas: Design system, Design Lab, web UI, generated offline styles
Motivation / Impact
Icon opacity was applied both inside SVG assets and by surrounding controls, making icons appear lighter than intended. Icon buttons also lacked the outlined circular specification and used inconsistent corner and interaction styles.
This change aligns these controls with UIKit while preserving ordinary Button dimensions, existing IconButton defaults, standalone icon opacity, and special artwork transparency.
Verification
Passed:
pnpm run design-system:checkpnpm run check:web— includes theme color audits and TypeScript checks.pnpm --dir src/web-ui exec vitest run --maxWorkers=50% src/app/components/NavPanel/sections/sessions/SessionsSectionLayout.test.ts— 9 tests passed.git diff --checkManual visual validation and live remote scenarios were not exercised.
Reviewer Notes
Checklist