feat(desktop): Add image export modes and fix Windows file reveal - #2900
Merged
Conversation
Offer compact images and images with thinking from the export menu. Keep thinking headers in compact exports and show the full reasoning in the detailed mode, with localized labels for all supported locales. Preserve the existing exploration and tool-card export behavior.
Use the existing opener integration to select files in Explorer. Passing /select and a path as one argument quotes the whole switch when filenames contain spaces, which can open the wrong location. Preserve directory opening and the macOS and Linux implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Feature / bug fix / UI/UX
Areas: Desktop/Tauri, Web UI, i18n
Motivation / Impact
Image exports previously always included expanded thinking content.
Users can now choose a compact image for sharing or include the full
thinking content.
On Windows, the previous implementation passed
/select,and the filepath as one command-line argument. Paths containing spaces caused the
entire argument to be quoted, which could make Explorer open its default
directory instead of selecting the exported file.
File reveal now uses the existing
tauri-plugin-openerintegration,which resolves files through the Windows Shell API.
Verification
Passed:
pnpm run type-check:webpnpm --dir src/web-ui exec tsc --noEmitpnpm --dir src/web-ui exec eslint src/flow_chat/components/modern/ExportImageButton.tsxpnpm run i18n:auditpnpm run theme:color-audit:allpnpm run fmt:rsgit diff --checkAdditional verification:
pnpm run motion:auditcompleted as an inventory check, not a pass/fail gate.the actual exported image and filenames containing spaces, Chinese
characters, brackets, dollar signs, and commas resolve to the correct
filesystem paths. The diagnostic program is not included in this PR.
cargo check -p openbitfun-desktopwas stopped while waiting for abuild lock held by another build; compilation verification is incomplete.
behavior, and remote scenarios were not exercised.
Reviewer Notes
“Image with thinking” does not expand all tool details.
other callers as well.
Checklist