fix(ui): prevent text descender clipping in components and navigation - #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Bug fix / UI/UX / test
Areas: Shared UI component library, web UI navigation, skills
Motivation / Impact
Tight line heights combined with overflow clipping cut off the lower parts of letters such as g, y, p, and q.
Affected text slots now use the existing base line-height token while preserving font sizes, weights, horizontal ellipsis, and the two-line skill description limit.
Verification
Completed during implementation:
pnpm run check:web— passed.pnpm run design-system:check— passed, including 174 UI tests and 52 Design Lab tests.node --test design-system/packages/ui/tests/text-clipping.test.mjs— 10 tests passed.git diff --check— passed.Manual visual verification and remote-scenario testing were not performed.
Reviewer Notes
333868481anddce49f064.Checklist