fix(ui): align icon sizing and settings navigation hierarchy - #2683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type and Areas
Type: Bug fix / UI/UX / test
Areas: Web UI, shared UI component library, Design Lab
Motivation / Impact
Catalog icons could appear larger than adjacent SVG icons because component slots did not constrain both representations consistently.
The settings sidebar also had crowded spacing and competing local styles, while group captions and destination labels lacked sufficient visual distinction.
These changes improve visual consistency across production components and Design Lab, clarify navigation hierarchy, and preserve existing navigation and search behavior.
Verification
Passed during implementation; not rerun while preparing this PR:
pnpm run check:web— passed appearance/theme checks and Web UI type checking.pnpm run design-system:check— passed builds, package checks, and tests, including 164 UI tests and 52 Design Lab tests.pnpm --dir src/web-ui exec vitest run src/app/scenes/settings/SettingsNavTypography.test.ts src/app/scenes/settings/SettingsNav.test.tsx src/app/scenes/settings/SettingsScene.test.tsx— 12 tests passed.Checked while preparing this PR:
git diff upstream/1.0.0-explore...HEAD --check— passed.Actual application visual checks and remote workspace, remote control, Peer Device Mode, and Detached Dispatch scenarios were not exercised.
Reviewer Notes
Checklist