fix(design-lab): correct component previews, prevent overlap and preserve menu focus rings - #2681
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: N/A
Type and Areas
Type: Bug fix / UI/UX / Test
Areas: Design Lab, shared React component library (@bitfun/ui), localization
Motivation / Impact
Some Design Lab details displayed the wrong component, wide specimens overlapped, and menu focus rings were partially clipped. These issues made component inspection and manual validation unreliable.
This change improves preview accuracy and readability. The shared Menu fix also preserves focus-ring visibility during real keyboard navigation.
Verification
The following commands passed during implementation; they were not rerun while preparing this PR description:
pnpm run design-system:checkpnpm run theme:color-audit:allgit diff --checkNew rendering tests cover actual Textarea specimens, the other incorrect Switch fallbacks, independent FieldGroup state containers, and explicit handling of unsupported previews.
Final visual validation remains manual. Verification was local only; remote scenarios were not exercised.
Reviewer Notes
Checklist