refactor(ui): add Combobox and nested menus, migrate Web UI controls - #2674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: N/A
Type and Areas
Type: Feature / bug fix / refactor / UI/UX / docs / test
Areas: Shared UI components, design system, Design Lab, Web UI, Appearance compatibility
Motivation / Impact
Reduce duplicated controls and inconsistent behavior across Web UI by moving reusable selection, menu, and layout patterns into the shared component library.
Standardize keyboard navigation, overlay positioning, and focus handling while keeping product-specific actions and infrastructure outside shared components.
Verification
Passed during implementation:
pnpm run design-system:check— package and Design Lab builds, type checks, and tests.pnpm run check:web— Web UI type checking, Appearance contracts, theme color audits, and visual contract checks.Not performed:
Reviewer Notes
components.selectAppearance overrides are ignored through the existing read-only migration mechanism. Original packages remain unchanged; legacy loading and JSON round-trip behavior are covered by tests.Checklist