fix(stellar): restore wallet-compatible sponsored authorization - #11
Utilitycoder wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package adds token approval sponsorship intents, updates Soroban authorization-entry signing, strengthens signing tests with real XDR, and releases version 0.2.2 with changelog documentation. ChangesStellar sponsorship flow
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant signSponsorshipAuthorization
participant authorizeEntry
participant config.signAuthEntry
signSponsorshipAuthorization->>authorizeEntry: pass authorization entry and expiration ledger
authorizeEntry->>config.signAuthEntry: request signature for base64 preimage
config.signAuthEntry-->>authorizeEntry: return signed authorization entry
authorizeEntry-->>signSponsorshipAuthorization: return signed entry bytes
Merge Risk: ⚪ Minimal · up to The new approval sponsorship intent and wallet-compatible authorization signing flow have no identified current-head defect. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes sponsored Stellar signing by sending the Soroban authorization preimage to the wallet, then inserting the returned signature into the relayer authorization entry. This restores the signing sequence used by the previously working integration and retains typed sponsorship intents.\n\nValidation: 22 tests passed, 3 testnet integration tests skipped; TypeScript typecheck and package build passed; npm pack dry run passed.
Summary by CodeRabbit
New Features
Documentation