Skip to content

Fix video view all playlist#9334

Closed
r3dArch wants to merge 0 commit into
FreeTubeApp:developmentfrom
r3dArch:development
Closed

Fix video view all playlist#9334
r3dArch wants to merge 0 commit into
FreeTubeApp:developmentfrom
r3dArch:development

Conversation

@r3dArch

@r3dArch r3dArch commented Jun 27, 2026

Copy link
Copy Markdown

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #629

Description

Creates a path for the view playlist button based on channel ID, allowing users to play all of a channel's videos.

Screenshots

Before
Grimshot 2026-06-26 21-53-12
After
Grimshot 2026-06-26 21-53-26

Testing

Desktop

  • OS: Arch Linux
  • OS Version: Kernel 7.0.10-zen-1-zen
  • FreeTube version: 0.24.1

Additional context

None

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 27, 2026 02:02
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2026
@r3dArch r3dArch marked this pull request as draft June 27, 2026 02:08
auto-merge was automatically disabled June 27, 2026 02:08

Pull request was converted to draft

@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2026
@r3dArch r3dArch marked this pull request as ready for review June 27, 2026 02:42
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 27, 2026 02:42
@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2026
@r3dArch r3dArch marked this pull request as draft June 27, 2026 07:09
auto-merge was automatically disabled June 27, 2026 07:09

Pull request was converted to draft

@github-actions github-actions Bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2026
@r3dArch

r3dArch commented Jun 27, 2026

Copy link
Copy Markdown
Author

After doing some more testing I found a better way to fix this so that it uses the getChannelPlaylistId function and works for popular videos and shorts. I had to change the type for finding the continuation, but I'm not sure if that is the correct way to fix that; and it seems as though the videos load all at once rather than lazily (that's what the continuation is for, right?). I also need to figure out why the shorts only load the first 100 videos, but that will have to wait until tomorrow.

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

Hi @r3dArch thanks for looking into this issue.

There is a better way to address this one by doing this.

Add play all buttons inside the relevant tabs and auto-pick the correct playlist based on the current tab and sort direction.

This has the advantage of it always showing instead of only when the channel has the videos, live or shorts sections added to their home tab.

Would it be possible for you to implement these changes?

@r3dArch

r3dArch commented Jun 27, 2026

Copy link
Copy Markdown
Author

Hi @efb4f5ff-1298-471a-8973-3d47447115dc , I think I understand what you mean and will try to implement that soon. Would you still want the current changes as well? Thank you.

@efb4f5ff-1298-471a-8973-3d47447115dc

Copy link
Copy Markdown
Member

Hi @r3dArch the requested changes will replace current so no need to keep current changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Play All button

2 participants