Conversation
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Traces" feature, allowing users to view detailed execution flows via a dedicated dialog instead of inline. Key changes include the addition of the TracesButton, TracesDialog, and NodeDetailsContent components, as well as a refactoring of workflow utilities into a shared workflowUtils.tsx file. Feedback focuses on improving security by using DOMPurify for markdown rendering, adding error handling to file download requests, and optimizing the tree data construction logic to avoid redundant mutations and code duplication.
mmattu-wd
left a comment
mmattu-wd
left a comment
There was a problem hiding this comment.
Looks good! Just one comment on hiding the cost
| {renderRenderedView()} | ||
| </Show> | ||
| </div> | ||
| <NodeDetailsContent |
| <TokenIcon /> {m().tokens} | ||
| </span> | ||
| </Show> | ||
| <Show when={m().cost}> |
There was a problem hiding this comment.
Can we put an option in to hide this in the initialization of the bot?
There was a problem hiding this comment.
If the model is not listed on models.json in Flowise, we will not calculate the cost, and hence it wont show the cost as well here
mmattu-wd
left a comment
mmattu-wd
left a comment
There was a problem hiding this comment.
Spoke too soon looks like there is a regression when opening the dialog in a provided portal outside the shadow-dom.
The previous component used in-line styles which prevented this issue from occurring where with this new change we are using some tailwind classes which wont work when we open in a portal.
I made some changes here I included the index.html changes if you want to test it out: e1fa3e5
good spot! i didnt test that. feel free to push your commit to this pr branch |
2 participants
Before:
After:
traces-ezgif.com-crop-video.mp4