Skip to content

task: smoother streaming with media#370

Draft
chloebyun-wd wants to merge 4 commits intomainfrom
task/smoother-streaming-with-media
Draft

task: smoother streaming with media#370
chloebyun-wd wants to merge 4 commits intomainfrom
task/smoother-streaming-with-media

Conversation

@chloebyun-wd
Copy link
Copy Markdown
Contributor

Add support for smoother media streaming:

  • keeps chat pinned to latest content more reliably during stream
  • handles post-render/media-size changes better for scrolling
  • reduces jank during streaming updates
  • avoids local storage pollution from incomplete/interrupted stream messages

 # links and colors are correct during streaming, not just at stream end
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the chat scrolling and message streaming logic to improve the user experience and optimize message persistence. Key changes include the introduction of an isStreaming flag to defer message updates, a scrollToBottom helper, and an onMessageRendered callback to handle dynamic content like images. Review feedback highlights a bug where auto-scrolling is blocked during streaming, performance concerns regarding manual DOM manipulation and internal component definitions, and the need to refine message cleanup logic to prevent the loss of partial metadata (tools, artifacts) during stream interruptions.

Comment thread src/components/bubbles/BotBubble.tsx Outdated
Comment thread src/components/bubbles/BotBubble.tsx Outdated
Comment thread src/components/bubbles/BotBubble.tsx Outdated
Comment thread src/components/Bot.tsx Outdated
Comment thread src/components/Bot.tsx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant