Draft
Conversation
# links and colors are correct during streaming, not just at stream end
There was a problem hiding this comment.
Code Review
This pull request refactors the chat scrolling and message streaming logic to improve the user experience and optimize message persistence. Key changes include the introduction of an isStreaming flag to defer message updates, a scrollToBottom helper, and an onMessageRendered callback to handle dynamic content like images. Review feedback highlights a bug where auto-scrolling is blocked during streaming, performance concerns regarding manual DOM manipulation and internal component definitions, and the need to refine message cleanup logic to prevent the loss of partial metadata (tools, artifacts) during stream interruptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for smoother media streaming: