Skip to content

Feature/fetch and display region specific restaurants on home view#33

Open
ebrahim-soliman wants to merge 20 commits into
mainfrom
feature/Fetch-and-Display-region-specific-restaurants-on-Home-View
Open

Feature/fetch and display region specific restaurants on home view#33
ebrahim-soliman wants to merge 20 commits into
mainfrom
feature/Fetch-and-Display-region-specific-restaurants-on-Home-View

Conversation

@ebrahim-soliman

@ebrahim-soliman ebrahim-soliman commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator
  • Update the merchant fakeDataPopulator code to generate the merchants (as-is) under a specific region. We'll do it for cape town only for now.
  • Build the LargeMerchantItem in the box_ui project
  • Add the LargeMerchantItem into the box_ui example to show how it'll look
  • Add the function in the FirestoreApi to get the merchants for a region when landing on home
  • Display that list through the ViewModel using a FutureViewModel
  • Show a busy indicator (just a basic CircularProgressIndicator),

Sorry for the pictures😂
It's from faker API I'll fix it later
Screenshot_1627378956

@FilledStacks FilledStacks left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest change we need to tackle is to make sure that we use the BoxText widget where ever text is used. That's why we build that design system separately. We should be using the style on its own.

Comment thread src/backend/functions/src/system/fakeDataPopulator.ts Outdated
Comment thread src/backend/functions/src/system/fakeDataPopulator.ts Outdated
Comment thread src/clients/box_ui/lib/src/widgets/large_merchants_item.dart Outdated
@ebrahim-soliman

Copy link
Copy Markdown
Collaborator Author

Done

@FilledStacks FilledStacks left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes for some consistency and general stacked guidelines. I'll do a proper review of the UI when I have the written tutorial.

Keep in mind how you would teach this. And make sure when writing that you don't have a large chunk of code. Rather break it into smaller steps. You can check the editted version of your tutorial on the website and you'll see how I broke your original DialogContent code into 3 different parts to make it easier to teach and explain.

Comment thread src/clients/customer/lib/ui/home/home_viewmodel.dart Outdated
Comment thread src/clients/customer/lib/ui/home/home_view.dart Outdated
Comment thread src/clients/customer/lib/ui/startup/startup_viewmodel.dart Outdated
Comment thread src/clients/customer/lib/api/firestore_api.dart Outdated
Comment thread src/clients/customer/lib/api/firestore_api.dart Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants