Optimize FancyHolograms visibility checks and text rendering - #310
Open
Bruhdows wants to merge 1 commit into
Open
Optimize FancyHolograms visibility checks and text rendering#310Bruhdows wants to merge 1 commit into
Bruhdows wants to merge 1 commit into
Conversation
Removed unnecessary HashSet copies in refresh methods and added global text caching to reduce redundant parsing of hologram text. These changes reduce CPU overhead when managing many holograms without changing the visibility check frequency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Description
Removed unnecessary HashSet copies in refresh methods and added global text caching to reduce redundant parsing of hologram text. These changes reduce CPU overhead when managing many holograms without changing the visibility check frequency.
✅ Checklist
mainbranch🔍 Changes
refreshForViewersInWorld()🧪 How to Test
/spark profiler start --thread FancyHolograms*(to isolate hologram thread)/spark profiler stopand check the CPU time in visibility checksforceUpdateShownStateFor()calls