fix(provisioning): size RegisterThing publish topic buffer to 150 - #137
Merged
Merged
Conversation
The RegisterThing publish topic was formatted into a 69-byte buffer while
the sibling accepted/rejected topics use 150. The publish topic
$aws/provisioning-templates/{template}/provision/{fmt} is 71 bytes for a
28-char template name (e.g. fleetDuoProvisioningTemplate), overflowing the
69-byte buffer and failing RegisterThing with Error::Overflow after the
subscribe and before the publish.
The publish topic is always shorter than its accepted/rejected variants (no
/accepted or /rejected suffix), so 150 matches them and is safely sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
RegisterThingpublish topic is formatted into a 69-byte buffer (provisioning/mod.rs:241,format::<69>()), while its sibling accepted/rejected topics useformat::<150>().The publish topic
$aws/provisioning-templates/{template}/provision/{fmt}is 71 bytes for a 28-char template name:$aws/provisioning-templates/fleetDuoProvisioningTemplate/provision/cbor71 > 69, so
Topic::formatoverflows andRegisterThingfails withError::Overflowafter the accepted/rejected subscribe and before the publish. Any provisioning template name longer than 26 characters hits this.The publish topic is always shorter than its accepted/rejected variants (no
/acceptedor/rejectedsuffix), so sizing it at 150 matches them and is safely sufficient.