Sprach- und Theme-Umschalter verbessern#148
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Diese PR verbessert die Internationalisierung und Theme-Steuerung in der LearnHub-UI, indem der Sprachumschalter als eigenes Dropdown (mit Flaggen) umgesetzt und ein wiederverwendbarer Theme-Button eingeführt wird, der nun auch auf Login/Registrierung verfügbar ist.
Changes:
- Sprachumschalter von nativen
<select>zu einem Custom-Dropdown mit Flaggen (DE/EN) umgebaut. - Gemeinsamen
ThemeToggleButtonerstellt und in Topbar sowie Auth-Layout integriert. - Übersetzungsbausteine ergänzt/korrigiert, um Deutsch/Englisch-Mix in zusammengesetzten Texten zu vermeiden.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/i18n/translations.ts | Ergänzt Phrase-Übersetzungen zur Vermeidung von Teilübersetzungen/Sprachmix. |
| src/lib/i18n/LanguageProvider.tsx | Ersetzt den Sprach-Select durch ein eigenes Dropdown inkl. Flaggen/Interaktionslogik. |
| src/components/ui/ThemeToggleButton.tsx | Neuer, wiederverwendbarer Theme-Umschalter für App- und Auth-UI. |
| src/components/login/AuthSplitLayout.tsx | Bringt Theme-Umschaltung (und Dark-Styles) auf Login/Registrierung. |
| src/components/layout/Topbar.tsx | Nutzt den neuen Theme-Button statt Inline-Implementierung. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Lennard79
force-pushed
the
smoother-language-theme
branch
from
6966925 to
bc5ecad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Änderungen
Warum
Der native Select wirkte optisch hart und zeigte keine Flaggen. Außerdem war der Theme-Wechsel bisher erst nach dem Login erreichbar. Eine Teilübersetzung führte zu Texten wie
alles in one place.Validierung
npm.cmd run lintnpm.cmd run typecheckgit diff --check