Repository navigation
watchfrr: don't admit to systemd that we restart (backport #23088) - #23093
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as low quality.
This comment was marked as low quality.
As of systemd 259 (98734ac74d16), once you're telling it that you're stopping, you're _stopping_, full stop. systemd will make sure of it. So, I guess we just shouldn't admit to systemd that we're restarting. Use `SIGUSR1` for reload instead, so it just gives systemd a bit of text instead. (cherry picked from commit 34a9f14) [conflict fixed] Fixes: #20430 References: systemd/systemd@98734ac Signed-off-by: David 'equinox' Lamparter <equinox@opensourcerouting.org>
eqvinox
force-pushed
the
mergify/bp/stable/10.5/pr-23088
branch
from
August 23, 2026 20:53
07bec46 to
7285545
Compare
Contributor
|
conflict fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of systemd 259 (98734ac74d16), once you're telling it that you're stopping, you're stopping, full stop. systemd will make sure of it.
So, I guess we just shouldn't admit to systemd that we're restarting.
Fixes: #20430
References: systemd/systemd@98734ac
This is an automatic backport of pull request #23088 done by Mergify.