Take the version base from a release tag only - #1757
Merged
Conversation
fog-version.sh took the newest tag of any name as the base version. The
tag archive/feature-fog2-gui, pushed on 2026-09-06, is now the newest
tag, so the dev arm computes archive/feature-fog2-gui.2479. The slash
breaks the sed in apply-fog-version.sh, and fog-workflows' daily sweep
has failed on dev-branch every day since. The stable arm has the same
defect.
Both the tag lookup and git describe now match release tags only
('[0-9]*'). tests/fog-version-release-tag.test.sh builds a fixture repo
with a release tag and a newer archive tag, and fails on the old script
with 'archive/feature-x.2'.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RANCjBL6XSavKYf58MZKZj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fog-workflows' daily sweep has failed on dev-branch every day since 2026-09-06, in "Apply version fix":
So
badges/dev-branch.jsonhas not updated since 2026-09-02.stable-releases.ymlreads its release tag from that file.Cause
fog-version.shtakes the newest tag of any name as the base version. The tagarchive/feature-fog2-guiwas pushed on 2026-09-06 and is now the newest tag. The dev arm computesarchive/feature-fog2-gui.2479, and the slash breaks thesedinapply-fog-version.sh. The stable arm uses the same lookup.Fix
git rev-list --tagsandgit describe --tagsnow match'[0-9]*'only. A release tag is the version string itself, so it starts with a digit.Verification
fog-version.sh dev-branch headgivesarchive/feature-fog2-gui.2479before and1.5.10.2479after.master..origin/dev-branch --countis 2479.tests/fog-version-release-tag.test.shbuilds a fixture repo with a release tag and a newer annotated archive tag. It passes with the fix. With the old script it fails withdev-branch computed 'archive/feature-x.2', expected '1.5.10.2', and the same for stable.Port of the working-1.6 PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RANCjBL6XSavKYf58MZKZj