Skip to content

fix: restore full release lint gate for booking transport release #140

Description

@chubes4

Problem

The authorized booking transport release from current main (6e6709e) is blocked by the configured Homeboy release lint gate.

Observed from homeboy release extrachill-api --apply on 2026-07-27:

  • PHPCS reports legacy errors across route files, including short ternaries and non-Yoda comparisons.
  • PHPStan level 7 reports 60 errors across 28 files.
  • Booking transport-specific findings include public-write-admission.php, route-affinity.php, booking-attachment-download.php, and booking-inquiries.php.
  • No release commit or tag was created.

Required outcome

  • Make the configured full Homeboy release lint gate pass without suppressing real findings or weakening analysis.
  • Preserve public API behavior and the merged booking transport contracts.
  • Add or retain focused tests where a type correction changes control flow.
  • Do not hand-edit version strings or changelog.
  • Merge green before retrying the v0.27.0 release.

Production impact

The protected booking inquiry route is merged but absent from the deployed v0.26.1 package. Lo-Fi production rehearsal is blocked until this gate passes and API is released/deployed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions