88500: Unexpected error does not appear in created report after enabling Failing network#89136
Open
abbasifaizan70 wants to merge 3 commits intoExpensify:mainfrom
Open
88500: Unexpected error does not appear in created report after enabling Failing network#89136abbasifaizan70 wants to merge 3 commits intoExpensify:mainfrom
abbasifaizan70 wants to merge 3 commits intoExpensify:mainfrom
Conversation
…ing Failing network
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
7 tasks
Contributor
|
@abbasifaizan70 You have some automated review comments above |
Contributor
Author
|
@dmkt9 Fixed AI feedbacks. |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.hybrid.mp4Android: mWeb Chromeandroid.chrome.mp4iOS: HybridAppios.hybrid.mp4iOS: mWeb Safariios.safari.mp4MacOS: Chrome / Safarimac.safari.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Wired the inbox ReportScreen to the report's errorFields.createReport (via getReportOfflinePendingActionAndErrors) and added a dismissReportCreationError callback that goes back and calls removeFailedReport.
Wrapped the report body in a second OfflineWithFeedback so the "Unexpected error creating this chat..." row now renders inbox-side (mirroring MoneyRequestReportView), letting the user dismiss the failed optimistic report instead of being stuck on it.
Fixed Issues
$ #88500
PROPOSAL: #88500 (comment)
Tests
Offline tests
Same as test.
QA Steps
Same as test.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-30.at.1.45.27.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-04-30.at.1.40.28.AM.mov
iOS: Native
Screen.Recording.2026-04-30.at.1.22.02.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-04-30.at.1.23.23.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-30.at.12.47.25.AM.mp4